532400 - Add a .crash() method to the testplugin

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Benjamin Smedberg]

In order to test crash reporting for plugin processes, we should have a method on the testplugin that crashes.

Comment 1

[Benjamin Smedberg]

Attachment: Add testplugin.crash(), rev. 0

This adds a .crash() method to the testplugin which kinda works when you run `make mochitest-ipcplugins`. Unfortunately, the parent process crashes in the next test, probably because the plugin module is invalid but the plugin host doesn't know that.... that might be fixed, or at least helped, by bug 529005

jgriffin, this test should only be run when IPC plugins are enabled. Could you figure out a way to make that happen?

Comment 2

[Benjamin Smedberg]

whoops, cc'ing jgriffin, please see comment 1

Comment 3

[Jonathan Griffin (:jgriffin)]

Attachment: Add testplugin.crash(), rev. 1

Unfortunately there's no really slick way to exclude a mochitest based on a preference, so I've added an "ifdef MOZ_IPC" in the makefile, and a preference read in the test itself.  Once OOPP are on by default, we can remove the preference read.

Someday it would be nice to convert mochitest to a manifest-based framework, so that it can more intelligently select tests based on the characteristics of the software-under-test.  I think this would be especially useful for dealing with mochitest on embedded devices.  But not today...

Comment 4

[Benjamin Smedberg]

Attachment: Add testplugin.crash(), rev. 2

Added a test for reloading, which should cause the plugin to be started over after a crash. I'll land this with bug 532751.

Comment 5

[Benjamin Smedberg]

http://hg.mozilla.org/mozilla-central/rev/c228f7ad2a50
followup for build bustage: http://hg.mozilla.org/mozilla-central/rev/c15b2b4cfbf2

See also bug 533482. The test is currently disabled waiting on pluginhost changes, but I'm re-enabling it in that bug 532751

Comment 6

[Benjamin Smedberg]

Re-enabled on mozilla-central at http://hg.mozilla.org/mozilla-central/rev/1cb8d8078bc5