532941 - [Collector Extension] Use nsIXULAppInfo.ID instead of name

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Collector Extension, defect, P1)

Description

[Brian King [:kinger]]

From bug 517291:

Bug 517291#15
Bloody mess… Previosly I use "case "Seamonkey": {", and it work fine.
Now I see "nothing working", and, when I trace with venkman, look into, and see
that appname="SeaMonkey".
Wtf?

It remember me to my previous patch for weave. See
https://bugzilla.mozilla.org/show_bug.cgi?id=526521#c17, last paragraph.

Edward Lee wrote: "We've run into issues before when switching on the
AppInfo.name instead of AppInfo.ID".

Maybe, bandwagon also affected by "issues"?

Bug 517291#16
nsIXULAppInfo has returned "SeaMonkey" (capital M) as the appname since
SeaMonkey 1.0. But as you say now that Bandwagon supports Fennec which at some
point will start identifying itself as "Firefox", the bandwagon developers
(like the weave developers) will have to bite the bullet and switch to using
appId from appname.

Comment 1

[Brian King [:kinger]]

Fixed.

http://viewvc.svn.mozilla.org/vc?revision=57715&view=revision

The add-on can now better distinguish between Firefox desktop and mobile.