533188 - Microsummary link for saved searches needs to escape search name

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Phil Ringnalda (:philor)]

STR:

1. Search for anything (that will return results), save the search as |foo+|
2. Load the saved search in Firefox
3. Bookmarks, Bookmark This Page, click the dropdown arrow in the Name: field in the bookmark dialog

Expected:

Below the "Live Titles" separator, the name of the search followed by the number of things in the list, like |foo+ (120)|

Actual:

The microsummary is |<!-- YAHOO.namespace...| because the name isn't being escaped, so instead of |?cmdtype=runnamed&amp;namedcmd=foo%25&amp;ctype=microsummary| the link is |?cmdtype=runnamed&amp;namedcmd=foo+&amp;ctype=microsummary| and the plus turns into a space on the server side and the namedcmd |foo | (or |foo|, either way) isn't found.

Comment 1

[Reed Loden [:reed]]

Attachment: patch - v1

$searchname was being added to the microsummary URL completely unfiltered.

Comment 2

[Dave Miller [:justdave]]

Comment on attachment 416360 [details] [diff] [review]
patch - v1

This has been applied on bugzilla-stage-tip, care to test it there?

Comment 3

[Reed Loden [:reed]]

(In reply to comment #2)
> (From update of attachment 416360 [details] [diff] [review])
> This has been applied on bugzilla-stage-tip, care to test it there?

Works.

bugzilla.mozilla.org:
       <link rel="microsummary"
             href="?cmdtype=runnamed&amp;namedcmd=sg:crit+crash&amp;ctype=microsummary">

bugzilla-stage-tip.mozilla.org:
       <link rel="microsummary"
             href="?cmdtype=runnamed&amp;namedcmd=sg%3Acrit%2Bcrash&amp;ctype=microsummary">

Comment 4

[Phil Ringnalda (:philor)]

Yup, works fine for the saved search case that I reported, though not surprisingly it doesn't fix what I didn't realize was a separate bug that I didn't report, that shared searches like https://bugzilla-stage-tip.mozilla.org/buglist.cgi?cmdtype=dorem&remaction=run&namedcmd=blocking-thunderbird3%2B&sharer_id=1537 will still fail because |IF searchname| believes all searches are your own.

Comment 5

[Reed Loden [:reed]]

(In reply to comment #4)
> Yup, works fine for the saved search case that I reported, though not
> surprisingly it doesn't fix what I didn't realize was a separate bug that I
> didn't report, that shared searches like
> https://bugzilla-stage-tip.mozilla.org/buglist.cgi?cmdtype=dorem&remaction=run&namedcmd=blocking-thunderbird3%2B&sharer_id=1537
> will still fail because |IF searchname| believes all searches are your own.

Can you file that separately, and I'll get a fix together for it? Thanks!

Comment 6

[Phil Ringnalda (:philor)]

Filed bug 533221

Comment 7

[Dave Miller [:justdave]]

Committed revision 6733, and deployed.

Comment 8

[Phil Ringnalda (:philor)]

Comment on attachment 416360 [details] [diff] [review]
patch - v1

What with one thing and another and another and another, probably don't really need this review request anymore.