533300 - Safe mode should prompt user for confirmation before to make changes and restart

Status: UNCONFIRMED

(Firefox :: General, enhancement)

Description

[Skippy le Grand Gourou]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.14) Gecko/2009090905 Fedora/3.0.14-1.fc10 Firefox/3.0.14
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.14) Gecko/2009090905 Fedora/3.0.14-1.fc10 Firefox/3.0.14

When you start in safe-mode, you have three options : 
* continue in safe mode
* quit
* make changes and restart

Given the potential importance of the changes, given it is placed right on the place where you expect an "OK" button, and given its ambiguous label, the third option should prompt the user for confirmation before to apply changes, in order to avoid particularly upsetting situations.

Reproducible: Always

Steps to Reproduce:
1.Start Firefox in safe-mode.
2.Check a few boxes.
3.Click by mistake on "make changes and restart".
Actual Results:  
All your preferences are lost.

Expected Results:  
You should be warned that you are about to lost all your settings.

Comment 2

[Daniel]

I started iceweasel with the -safe-mode option, and partially due to the asinine GTK button order, I clicked "Make changes and restart" instead of "Continue in safe mode". 

In addition to the browser's settings, I also lost settings for my extensions. For example, all sites I whitelisted in Noscript and Flashblock are gone.

All this happened without warning, and absolutely no backup of any kind was performed on my ~/.mozilla directory.

I think at the very least an "are you sure" dialog should have been offered, and probably something like "back up your settings before overwriting all of them".

I really don't think my extensions settings should have been touched.

I'm also pretty irritated to see that this bug was originally filed in version 3.0 and it still exists in 6.0.