533498 - Build config changes for Cocoa Printing

Status: RESOLVED FIXED

(Calendar :: Build Config, defect)

Description

[Philipp Kewisch [:Fallen][☁️📆]]

+++ This bug was initially created as a clone of Bug #520394 +++

Lurking behind the bug 533458 trunk Mac failure is another: we try to rsync PrintPDE.plugin, but it's no longer built by default, because the default is now to use the bug 456646 Cocoa print dialog. Since that uses the bug 389074 Core Text check to define ac_cv_have_leopard, it's simpler just to port them both.

Comment 1

[Philipp Kewisch [:Fallen][☁️📆]]

Attachment: Fix - v1

This fixes. I'm not 100% sure about the ifdefs for removed-files.in, but philor should probably know best!

Comment 2

[Philipp Kewisch [:Fallen][☁️📆]]

Attachment: Fix - v2

Wrong ifdefs, this patch does it better. I've tested this patch on trunk for mac at 

http://tinderbox.mozilla.org/showlog.cgi?log=ThunderbirdTry/1260353519.1260359098.28553.gz

Comment 3

[Philipp Kewisch [:Fallen][☁️📆]]

This causes build breakage, changing importance. I'd appreciate a review!

Comment 4

[Phil Ringnalda (:philor)]

Comment on attachment 416746 [details] [diff] [review]
Fix - v2

r=me without the ifdefs, since you don't need them post-branching

Comment 5

[Philipp Kewisch [:Fallen][☁️📆]]

Done, thanks!

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/838c816cdac1>

-> FIXED

Comment 6

[Philipp Kewisch [:Fallen][☁️📆]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".