533997 - Set up one repo for release repository testing, and another repo for the live release

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Seth Bindernagel]

We need to set up release repositories for Fennec single locale builds.

Comment 1

[Aki Sasaki [:aki] (he/him) (UTC-6)]

We need to figure out where these go.

mobile/repos/* will be one of these; not sure if they should be in bouncer or not (mounted somewhere?)  If they are in bouncer, we can potentially measure both nightlies and releases.

The release-testing repos should probably be accessible to the community, but not be advertised as the place to download the release.

I'll make my stuff generic so we can change these locations. Not sure who makes the decision though.

Comment 2

[Aki Sasaki [:aki] (he/him) (UTC-6)]

I'm currently thinking mobile/candidates/1.0rc1-candidates/repos/ as the candidate release testing repo area, mobile/repos/ for live nightly and release debs.

Comment 3

[Aki Sasaki [:aki] (he/him) (UTC-6)]

Attachment: signdebs.mk fix

'Cause I've been tormenting nthomas and bhearsum.  nthomas does know this code better than anyone but me, though, so I can pester him again if that's best.

This also contains the fixes for bug 533341.

- allow for a staging repo working area, so the same slaves can be used for staging and production without dirtying each others' local repos
- rebuild the install file every time, but get rid of the non-functional touch workdir
- allow for a new repo
- remove tmp.deb in case the makefile errors out during xulrunner-hack.

Comment 4

[Aki Sasaki [:aki] (he/him) (UTC-6)]

Attachment: updates to get release candidate repos / release repos working

http://staging-mobile-master.mv.mozilla.com:8011/waterfall
http://staging-mobile-master.mv.mozilla.com/debtest/
http://staging-mobile-master.mv.mozilla.com/debtest/candidates/

Comment 5

[Chris AtLee [:catlee]]

Comment on attachment 418129 [details] [diff] [review]
signdebs.mk fix

> download-repository:
>-	rsync -azv -e 'ssh -i $(SSH_KEY)' $(RSYNC_ARGS) $(STAGE_USERNAME)@$(STAGE_SERVER):$(STAGE_PATH)/dists/. $(WORKDIR)/dists/.
>+	ssh -i $(SSH_KEY) $(STAGE_USERNAME)@$(STAGE_SERVER) "test -d $(STAGE_PATH)/dists" && \
>+	  rsync -azv -e 'ssh -i $(SSH_KEY)' $(RSYNC_ARGS) $(STAGE_USERNAME)@$(STAGE_SERVER):$(STAGE_PATH)/dists/. $(WORKDIR)/dists/. || \
>+	  echo "No repository to download."

Are you intending for this to ignore the error if there's no repository to download?  I think this will return 0 if there's no repo, and so future steps will still proceed.

Comment 6

[Chris AtLee [:catlee]]

Comment on attachment 418130 [details] [diff] [review]
updates to get release candidate repos / release repos working

rubber-stamp applied.  I don't see anything wrong with this patch, but I also don't know what I'm looking for.

I'm curious why you moved get_fennecURL to an instance method.

Comment 7

[Aki Sasaki [:aki] (he/him) (UTC-6)]

(In reply to comment #5)
> Are you intending for this to ignore the error if there's no repository to
> download?  I think this will return 0 if there's no repo, and so future steps
> will still proceed.

True. I can remove the echo.

> I'm curious why you moved get_fennecURL to an instance method.

I wanted to check self.release, and don't know how to get self from build.

Comment 8

[Aki Sasaki [:aki] (he/him) (UTC-6)]

(In reply to comment #5)
> Are you intending for this to ignore the error if there's no repository to
> download?  I think this will return 0 if there's no repo, and so future steps
> will still proceed.

Oh, I think I misunderstood your question.

Yes, I want it to proceed.  Otherwise we'll have to create a dummy repo on the server any time we add a new branch or locale or repository location.  The final "|| echo ..." is probably unnecessary, but I do want to catch the error on "test -d" since I want it to proceed.

Comment 9

[Aki Sasaki [:aki] (he/him) (UTC-6)]

Comment on attachment 418129 [details] [diff] [review]
signdebs.mk fix

http://hg.mozilla.org/build/tools/rev/b39747f8efd3

Comment 10

[Aki Sasaki [:aki] (he/him) (UTC-6)]

Comment on attachment 418130 [details] [diff] [review]
updates to get release candidate repos / release repos working

http://hg.mozilla.org/build/buildbot-configs/rev/c40e578c5e93

Comment 11

[Aki Sasaki [:aki] (he/him) (UTC-6)]

I'm going to work on documenting all this now.