53448 - GetSelectorText is always returning null

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Marc Attinasi]

As a fix to bug 51944, the mSelectorText data member of nsCSSSelector was
removed. As a result, GetSelectorText was temporarily reimplemented to return
null. It should create a new selector and return that. Any clients of
GetSelectorText are now broekn, so this should be addressed soon.

Comment 1

[R. Saravanan]

The XMLterm component was using GetSelectorText through JS DOM and it used to
work correctly for changing styles interactively. See
http://lxr.mozilla.org/seamonkey/source/extensions/xmlterm/ui/content/XMLTermCommands.js#307
Because of the fix to bug 51944, this feature is broken.It would be nice to be
able to access the selectorText property correctly through DOM as soon as
possible.

Comment 2

[R. Saravanan]

Attachment: Simple HTML file as a test case to access selectorText through DOM.

Comment 3

[Marc Attinasi]

Accepting and setting milestone, but this will nto get fixed for RTM

Comment 4

[Marc Attinasi]

Setting milestone now to Future: this will be dealt with after RTM. If this
needs to get in for RTM please make the case for it and nominate RTM in the
keyword field.

Comment 5

[R. Saravanan]

At the moment I'm using an ugly workaround where I read all the CSS rules as
plain text, parse out the rule names myself, and use it to index the cssRules
DOM array. It works, but it is fragile and far from elegant. So the fix can wait
until after RTM, but will hopefully happen soon thereafter.

Comment 6

[Marc Attinasi]

Was this fixed when Hewitt fixed bug 52381? Seems like it should have been...

Comment 7

[Marc Attinasi]

Hewitt fixed bug 52381, I retested this with his fix and it works.
The console shows
  selectorText = 'span.test' (correct value is 'SPAN.test')
when the testcase is opened in Viewer.

Marking FIXED - thanks to Hewitt!

Comment 8

[Hixie (not reading bugmail)]

Netscape's standard compliance QA team reorganised itself once again, so taking 
remaining non-tables style bugs. Sorry about the spam. I tried to get this done 
directly at the database level, but apparently that is "not easy because of the 
shadow db", "plus it screws up the audit trail", so no can do...

Comment 9

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

*** Bug 62611 has been marked as a duplicate of this bug. ***

Comment 10

[Madhur Bhatia]

v