Port |Bug 499417 - Refactor login manager's crypto code| to SeaMonkey

VERIFIED FIXED in seamonkey2.1a1

Status

SeaMonkey
Build Config
--
major
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

({fixed-seamonkey2.0.3})

Trunk
seamonkey2.1a1
fixed-seamonkey2.0.3
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

8 years ago
Created attachment 417419 [details] [diff] [review]
(Av1) Fix m-c and m-1.9.2
[Checkin: Comment 8]
Attachment #417419 - Flags: review?(kairo)
(Assignee)

Comment 2

8 years ago
Created attachment 417420 [details] [diff] [review]
(Bv1-191) Support downgrading
[Checkin: Comment 9]
Attachment #417420 - Flags: approval-seamonkey2.0.2?
I don't know why you're touching 1.9.1 and 1.9.2 code, bug 499417 isn't going to land there.
(Assignee)

Comment 4

8 years ago
(In reply to comment #3)

To "support downgrading": "better safe than sorry."
I don't see what that's needed or even a good idea. But hey, it's your product, knock yourself out.

Comment 6

8 years ago
Dolske, as far as I remember, the Firefox removed-files was changed in similar ways to allow downgrading from one release to another. If that wouldn't have happened, I'd not allow such patches in SeaMonkey either, as that file is already too hard to read in any case (and it probably will still get worse over time) :(
(Assignee)

Comment 7

8 years ago
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.3a1pre) Gecko/20091214 SeaMonkey/2.1a1pre] (nightly) (W2Ksp4)
{
Failed to load XPCOM component: ...\components\crypto-SDR.js
}
And saved passwords list is empty, etc :-(
Severity: trivial → major
(Assignee)

Updated

8 years ago
Blocks: 534589

Updated

8 years ago
Attachment #417419 - Flags: review?(kairo) → review+

Updated

8 years ago
Attachment #417420 - Flags: approval-seamonkey2.0.2? → approval-seamonkey2.0.2+
(Assignee)

Comment 8

8 years ago
Comment on attachment 417419 [details] [diff] [review]
(Av1) Fix m-c and m-1.9.2
[Checkin: Comment 8]


http://hg.mozilla.org/comm-central/rev/831b6ccab4a7
Attachment #417419 - Attachment description: (Av1) Fix m-c and m-1.9.2 → (Av1) Fix m-c and m-1.9.2 [Checkin: Comment 8]
(Assignee)

Comment 9

8 years ago
Comment on attachment 417420 [details] [diff] [review]
(Bv1-191) Support downgrading
[Checkin: Comment 9]


http://hg.mozilla.org/releases/comm-1.9.1/rev/1cc0cd87a5f3
Attachment #417420 - Attachment description: (Bv1-191) Support downgrading → (Bv1-191) Support downgrading [Checkin: Comment 9]
(Assignee)

Updated

8 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: fixed-seamonkey2.0.2
Resolution: --- → FIXED
(Assignee)

Comment 10

8 years ago
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.3a1pre) Gecko/20091215 SeaMonkey/2.1a1pre] (nightly, 2009-12-15-10) (W2Ksp4)

V.Fixed.
Status: RESOLVED → VERIFIED

Comment 11

8 years ago
(In reply to comment #10)
> SeaMonkey/2.1a1pre] (nightly, 2009-12-15-10) (W2Ksp4)
> 
> V.Fixed.

Looks like its not fixed in trunk-builds yet.
(Assignee)

Comment 12

8 years ago
(In reply to comment #11)
> Looks like its not fixed in trunk-builds yet.

Which builds specifically? (Which steps?)

Comment 13

8 years ago
(In reply to comment #11)

> Looks like its not fixed in trunk-builds yet.

It is fixed in my private builds on Linux. You are using Windows NT 6.0; de-DE and i am not sure, if this is a clobber build.

Comment 14

8 years ago
(In reply to comment #12)
> (In reply to comment #11)
> > Looks like its not fixed in trunk-builds yet.
> 
> Which builds specifically? (Which steps?)

ftp://ftp.mozilla.org/pub/mozilla.org/seamonkey/tinderbox-builds/comm-central-trunk-win32/

From platform.ini:
[Build]
BuildID=20091216022627
Milestone=1.9.3a1pre
SourceStamp=f8d2c6f4631d
SourceRepository=http://hg.mozilla.org/mozilla-central
(Assignee)

Comment 15

8 years ago
(In reply to comment #14)

> ftp://ftp.mozilla.org/pub/mozilla.org/seamonkey/tinderbox-builds/comm-central-trunk-win32/

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.3a1pre) Gecko/20091216 SeaMonkey/2.1a1pre] (comm-central-trunk-win32/1260970429) (W2Ksp4)

> From platform.ini:
> BuildID=20091216022627
> SourceStamp=f8d2c6f4631d
> SourceRepository=http://hg.mozilla.org/mozilla-central

application.ini:
BuildID=20091216053349
SourceRepository=http://hg.mozilla.org/comm-central
SourceStamp=d25bb34f4cce

Well, you're right that the P.M. list is empty,
but I don't see this bug error in the console:
ftb, I can only assume that this is a side-effect of one of the multiple other packaging errors our 2.1 "hourlies" still have.

NB: Don't file bugs about these errors, I'm working on fixing packaging...

Comment 16

8 years ago
(In reply to comment #15)
> Well, you're right that the P.M. list is empty,
> but I don't see this bug error in the console:

Do you look for this?
http://lahls.de/temp/pic/errorconsole.png (112KB) You may pay attentions for the first line!

> ftb, I can only assume that this is a side-effect of one of the multiple other
> packaging errors our 2.1 "hourlies" still have.

ACK.

> NB: Don't file bugs about these errors, I'm working on fixing packaging...

Sorry, I thought, the packaging was already fixed.
(Assignee)

Comment 17

8 years ago
(In reply to comment #16)

> http://lahls.de/temp/pic/errorconsole.png (112KB) You may pay attentions for
> the first line!

This nsSuiteGlue.js error comes after the packaging errors on first profile use,
then it comes alone (on my local Windows).
That's why (or anyway) I think it's better to fix the latters before looking into the former.

I have no idea why you still get crypto-SDR.js error(s).

> > NB: Don't file bugs about these errors, I'm working on fixing packaging...
> 
> Sorry, I thought, the packaging was already fixed.

Your report(s) is appreciated.
But "hourlies" are meant for developer use "only" and maybe you shouldn't bother with them (atm).
(Assignee)

Comment 18

8 years ago
(In reply to comment #17)
> it's better to fix the latters before looking into the former.

Now I've filed bug 535462.
You need to log in before you can comment on or make changes to this bug.