534652 - White area surrounding content document on nightly builds

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aakash Desai [:aakashd]]

Build Id:
Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b5pre) Gecko/20091214 Firefox/3.6b5pre Fennec/1.0b6pre

and

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20091214 Firefox/3.7a1pre Fennec/1.0b5

Note: I see this on nightlies from 12/12 as well.

Steps to Reproduce:
1. Go to any webpage (preferably something dark like www.newgrounds.com
2. Look at the space in-between the url bar and the webpage as well as the left and right sides of the page

Actual Results:
There's a white spacing between content and chrome

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

This is a followup of bug 534054

Comment 2

[Benjamin Stover (:stechz)]

I'm wondering if subtracting 1 for (x,y) is actually necessary in the drawWindow call.  I think it's just offsetting drawing by (1,1) and this is compensating for that.

We should try reverting that particular part of doug's patch and see if we regress on the black lines.

Comment 3

[Stuart Parmenter]

The tiles are in the right position (i.e. (0,0) for the first tile) -- we definitely don't want to put them starting at -1,-1.  Is there some padding or somesuch on the outer elements?

Comment 4

[Benjamin Stover (:stechz)]

Attachment: Remove drawWindow x/y offset

After testing 1) none of doug's drawWindow offsets 2) the way it is now and 3) just doug's width/height offsets, I think #3 is the right thing.

#3 seems to reduce the black lines (like #2), but it doesn't offset tiles by 1,1.

Comment 5

[Doug Turner (:dougt)]

http://hg.mozilla.org/mobile-browser/rev/34179ce6dd5c

Thanks Vivien and Ben!

Comment 6

[Aakash Desai [:aakashd]]

verified FIXED on builds:
Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b5pre) Gecko/20091223 Firefox/3.6b5pre Fennec/1.0b6pre

and

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20091223 Firefox/3.7a1pre Fennec/1.0b5