534831 - Mailing List dialog not resizable

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, enhancement)

Description

[:Hb]

The Mailing List dialog window should be resizable as in Thunderbird.

Comment 1

[Philip Chee]

The Mailing List dialogs (New List, Edit List) are not resizable in Shredder either.

Comment 2

[Karsten Düsterloh]

While this may be true (I didn't check) that actually isn't an argument. ;-)

Comment 3

[Philip Chee]

In which case this should be an enhancement bug not a bugfix bug.

Comment 4

[Karsten Düsterloh]

You're right...

Comment 5

[Philip Chee]

Attachment: Patch v1.0 resizable mailing list dialogs.

> The Mailing List dialog window should be resizable as in Thunderbird.
Minimal patch.

Comment 6

[Karsten Düsterloh]

Comment on attachment 434524 [details] [diff] [review]
Patch v1.0 resizable mailing list dialogs.

Okay in a minimal way, although my KDE doesn't care anyway (I can resize all windows, hence I tested on Mac. 

MXRing for resizable=no it seems that only addressbook stuff is affected anyway, so maybe it's worth fixing all these in one row.

Furthermore, I noticed two glitches:
- the resized dialogs don't remember their size 
- abListOverlay.xul sports some odd <spacer flex="1"/> elements which push the mailing list header textboxen to the right edge. That looks very weird. Unfortunately, that file is shared (although a decent fix should be possible still).

Comment 7

[Karsten Düsterloh]

(In reply to comment #6)
> Unfortunately, that file is shared

Oh, but it isn't! So we could just move it home...

Comment 8

[Philip Chee]

Comment on attachment 434524 [details] [diff] [review]
Patch v1.0 resizable mailing list dialogs.

> MXRing for resizable=no it seems that only addressbook stuff is affected
> anyway, so maybe it's worth fixing all these in one row.

> Furthermore, I noticed two glitches:
> - the resized dialogs don't remember their size

Should they remember their size? What is the suite policy about remembering the size in resizable dialogs?

> - abListOverlay.xul sports some odd <spacer flex="1"/> elements which push the
> mailing list header textboxen to the right edge. That looks very weird.

CVS blame says that this has been the case since checkin (although they were springs initially).

> Unfortunately, that file is shared (although a decent fix should be possible
> still).

> Oh, but it isn't! So we could just move it home...

A separate bug perhaps for all these glitches?

Comment 9

[Philip Chee]

> MXRing for resizable=no it seems that only addressbook stuff is affected
> anyway, so maybe it's worth fixing all these in one row.

OK.

> - the resized dialogs don't remember their size

I'll fix the Mail List dialogs, but the others appear to be shared with TB.

> - abListOverlay.xul sports some odd <spacer flex="1"/> elements which push the
> mailing list header textboxen to the right edge. That looks very weird.

Filed Bug 555452 for this issue.

Comment 10

[Philip Chee]

>> MXRing for resizable=no it seems that only addressbook stuff is affected
>> anyway, so maybe it's worth fixing all these in one row.
> OK.

After testing a bit, I've decided that it makes no sense to make the other dialogs resizable since the sizes of the contents of these don't resize.

I'm not sure of the utility of making the mailing list dialogs resizable either after testing. Neil?

Comment 11

[[e-mail]]

Once bug 555452 is fixed I have no objection to making them resizable, but I am as yet undecided as to whether the size and/or position should be persisted.

Comment 12

[Karsten Düsterloh]

(In reply to comment #11)
> I am as yet undecided as to whether the size and/or position should
> be persisted.

My personal reasoning would go along the lines of "If I'm allowed to resize this dialog and I want to as well, it should stay that size." 
Resizable dialogs which snap back to their own size are pretty much annoying, IMO.

Comment 13

[Philip Chee]

My opinion, less is more. Leave the persists off until someone (a real user *not* *you*) complains and files a bug.

Comment 14

[Philip Chee]

checked-in http://hg.mozilla.org/comm-central/rev/17e1829c4c41