535422 - Language code 'dsb' not recognised by spellchecker language selector

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[derbeth.fora]

User-Agent:       Opera/9.64 (Windows NT 5.1; U; de) Presto/2.1.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.9.1.6) Gecko/20091201 Firefox/3.5.6 (.NET CLR 3.5.30729)

There are two add-ons:
https://addons.mozilla.org/de/firefox/addon/3956
https://addons.mozilla.org/de/firefox/addon/13201

If I install the first, dictionary files 'hsb.dic' and 'hsb.aff' are used. If I install the second, dictionary files 'dsb.dic' and 'dsb.aff' are used. When I right-click on a text field and select language for the spellchecker, I have on my list localized 'Upper Sorbian' (for 'hsb') and 'dsb' (for 'dsb').



Reproducible: Always

Steps to Reproduce:
1. Download and install the add-on https://addons.mozilla.org/de/firefox/addon/13201
2. Visit some page with multi-line text field
3. Right click on the text field and try to choose a language
Actual Results:  
'dsb' for Lower Sorbian language

Expected Results:  
Since both 'dsb' and 'hsb' are valid ISO-639-2 language codes (http://en.wikipedia.org/wiki/Lower_Sorbian_language http://en.wikipedia.org/wiki/Upper_Sorbian_language), I would expect having localized name of Lower Sorbian language displayed in spellchecker.

Comment 1

[Michael Wolf]

Reason is a missing entry in file languageNames.properties: There should be the entry "dsb=Lower Sorbian".

Comment 2

[Caolan McNamara]

Attachment: patch for this and other language codes

Attached is a patch to add this language code, and language codes of other dictionaries available in Fedora 13 which don't currently get assigned Human readable names in the Firefox spell checker list

Comment 3

[Caolan McNamara]

I imagine that this should probably be assigned to the same component and assignee as similar but resolved bug 532496

Comment 4

[Gordon P. Hemsley [:GPHemsley]]

Attachment: Add support for Lower Sorbian [dsb]

To keep things simple, creating a patch for adding only Lower Sorbian [dsb].

Comment 5

[Simon Montagu :smontagu]

Comment on attachment 658101 [details] [diff] [review]
Add support for Lower Sorbian [dsb]

Review of attachment 658101 [details] [diff] [review]:
-----------------------------------------------------------------

Need to patch langGroups.properties also

Comment 6

[Michael Wolf]

(In reply to Simon Montagu from comment #5)
> Comment on attachment 658101 [details] [diff] [review]
> Add support for Lower Sorbian [dsb]
> 
> Review of attachment 658101 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Need to patch langGroups.properties also

Fine that this bug will be fixed soon.

If you set the encoding in langGroups.properties use please "x-central-euro", not x-western. 

If it is possible, change this for Upper Sorbian (hsb) as well. At present "hsb=x-western" is displayed there, should be "hsb=x-central-euro". I know that is another bug (but I think a not filed one) but it would be good if you could change this as well when you will modify this file for dsb.

Thanks,
Michael

Comment 7

[Gordon P. Hemsley [:GPHemsley]]

Attachment: Add support for Lower Sorbian [dsb] (v2)

Include langGroups (x-central-euro).

Comment 8

[Gordon P. Hemsley [:GPHemsley]]

(In reply to Michael Wolf from comment #6)
> If it is possible, change this for Upper Sorbian (hsb) as well. At present
> "hsb=x-western" is displayed there, should be "hsb=x-central-euro". I know
> that is another bug (but I think a not filed one) but it would be good if
> you could change this as well when you will modify this file for dsb.

Spun off into bug 791027.

Comment 9

[Gordon P. Hemsley [:GPHemsley]]

See bug 716321 comment 14 for checkin information.

Comment 10

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/114505455432

Comment 11

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

https://hg.mozilla.org/mozilla-central/rev/114505455432