Closed
Bug 791027
Opened 13 years ago
Closed 13 years ago
Change Upper Sorbian [hsb] langGroup to x-central-euro
Categories
(Core :: Internationalization, defect)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: GPHemsley, Assigned: GPHemsley)
Details
Attachments
(1 file, 1 obsolete file)
818 bytes,
patch
|
GPHemsley
:
review+
|
Details | Diff | Splinter Review |
It doesn't seem that x-western covers the entirety of Upper Sorbian; x-central-euro is more appropriate (at least for the time being).
Attachment #660903 -
Flags: review?(smontagu)
Attachment #660903 -
Flags: review?(jfkthame)
Comment 1•13 years ago
|
||
Comment on attachment 660903 [details] [diff] [review]
Change Upper Sorbian [hsb] langGroup to x-central-euro
Review of attachment 660903 [details] [diff] [review]:
-----------------------------------------------------------------
::: intl/locale/src/langGroups.properties
@@ +74,5 @@
> he=he
> hi=x-devanagari
> hil=x-western
> hr=x-central-euro
> # XXX Latin Ext. A is also used for hsb.
I think you can remove this comment, or at least the XXX, since this is no longer an open issue with this change.
Attachment #660903 -
Flags: review?(smontagu) → review+
Comment 2•13 years ago
|
||
Hello Gordon,
thank you for opening this bug.
Yes, Upper Sorbian (hsb) and Lower Sorbian (dsb) are West Slavic languages like Czech, Polish and Slovak. They all use x-central-euro.
Assignee | ||
Comment 3•13 years ago
|
||
I decided to axe the comment altogether. (I also included a commit message!)
Assignee: nobody → gphemsley
Attachment #660903 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #660903 -
Flags: review?(jfkthame)
Attachment #660908 -
Flags: review+
Assignee | ||
Comment 4•13 years ago
|
||
Note for checkin: This patch assumes bug 586085. (See also: bug 716321 comment 14.)
Keywords: checkin-needed
Comment 5•13 years ago
|
||
Flags: in-testsuite-
Keywords: checkin-needed
Comment 6•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in
before you can comment on or make changes to this bug.
Description
•