Closed Bug 53558 Opened 24 years ago Closed 23 years ago

Windows Classic theme should not use ThreeDFace for borders

Categories

(SeaMonkey :: Themes, defect, P5)

Product:
SeaMonkey
Component:
Themes
Platform:
x86
Windows 95
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.6

People

(Reporter: neil, Assigned: shliang)

References

(
URL
)

Details

Attachments

(2 files, 1 obsolete file)

replaced some 3dface with 3dlightshadow
16.02 KB, patch
Details | Diff | Splinter Review
doing this over
16.30 KB, patch
jag+mozilla
: review+
hewitt
: superreview+
Details | Diff | Splinter Review
All insets (and outsets) currently using threedface and threeddarkshadow should all be using threedlightshadow instead of threedface.
Sending to Joe
Assignee: hangas → hewitt
Status: NEW → ASSIGNED
Don't think is gonna get approved for RTM. Marking P5 future.
Priority: P3 → P5
Target Milestone: --- → Future
marking dup *** This bug has been marked as a duplicate of 57429 ***
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → DUPLICATE
Verified dup.
Status: RESOLVED → VERIFIED
ThreeDFace should only be used for control backgrounds. Borders for focus effects should use transparent. Borders for inset and outset effects should use ThreeDLightShadow. Follow the URL to see a list of the offending styles.
URL: http://lxr.mozilla.org/seamonkey/sear...
Status: VERIFIED → REOPENED
Resolution: DUPLICATE → ---
Summary: Windows Classic theme should use threedlightshadow for insets → Windows Classic theme should not use ThreeDFace for borders
Status: REOPENED → ASSIGNED
Mass reassigning some of my theme bugs to Shuehan.
Assignee: hewitt → shliang
Status: ASSIGNED → NEW
Status: NEW → ASSIGNED
Target Milestone: Future → mozilla0.9.6
Blocks: 105174
Attached patch doing this over (obsolete) — — Splinter Review
Attachment #55314 - Attachment is obsolete: true
Attached patch doing this over — — Splinter Review
Comment on attachment 55354 [details] [diff] [review] doing this over r=jag
Attachment #55354 - Flags: review+
Comment on attachment 55354 [details] [diff] [review] doing this over sr=hewitt
Attachment #55354 - Flags: superreview+
checked in
Status: ASSIGNED → RESOLVED
Closed: 24 years ago → 23 years ago
Resolution: --- → FIXED
Verified the patch.
Status: RESOLVED → VERIFIED
Blocks: 110254
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: