Closed
Bug 535643
Opened 16 years ago
Closed 16 years ago
kill/replace nsPluginInstanceTagList
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jaas, Assigned: jaas)
References
Details
Attachments
(1 file, 2 obsolete files)
|
44.95 KB,
patch
|
Details | Diff | Splinter Review |
We should remove/replace nsPluginInstanceTag and nsPluginInstanceTagList. They are poorly designed and their mismanagement has resulted in too many bugs. They make the host->plugin->instance hierarchy harder to manager and store duplicate state that can get out of sync with other objects. They are not exported outside of the module like nsPluginTag is.
I was just looking at that code and wondering why we need these objects :-)
Summary: remove/replace nsPluginInstanceTag and nsPluginInstanceTagList → replace nsPluginInstanceTag and nsPluginInstanceTagList
Attachment #422310 -
Attachment is obsolete: true
Comment on attachment 422329 [details] [diff] [review]
kill nsPluginInstanceTagList, v1.0
This seems to work well. Cuts down on the insanity considerably, sets us up to do a lot more cleanup.
Attachment #422329 -
Flags: review?(jst)
|
||
Comment 5•16 years ago
|
||
Comment on attachment 422329 [details] [diff] [review]
kill nsPluginInstanceTagList, v1.0
Looks good.
Attachment #422329 -
Flags: review?(jst) → review+
Making this bug just about nsPluginInstanceTagList, I'll file new bugs on the other stuff.
Summary: replace nsPluginInstanceTag and nsPluginInstanceTagList → kill/replace nsPluginInstanceTagList
Updated to current trunk, got rid of an unused variable I forgot about.
Attachment #422329 -
Attachment is obsolete: true
pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/aa9d33fc9493
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Comment 9•15 years ago
|
||
This caused SM crash bug 573055.
|
||
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•