Closed
Bug 535660
Opened 15 years ago
Closed 15 years ago
improve plugin instance stopped/started state management
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jaas, Assigned: jaas)
References
Details
Attachments
(1 file, 1 obsolete file)
|
23.40 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
This patch improves plugin instance stopped/started state management. It gets rid of the duplicate state storage and introduces the invariant that a plugin instance tag much always have a valid nsNPAPIPluginInstance. It also fixes a bug in which the state can get out of sync. This is part of bug 535643, it moves state out of nsPluginInstanceTag, brings us one step closer to being able to kill it.
Attachment #418268 -
Flags: review?(roc)
I think this would be a good time to replace PRTime with mozilla::TimeStamp.
(otherwise, the patch looks fine)
Attachment #418268 -
Attachment is obsolete: true
Attachment #418268 -
Flags: review?(roc)
Wow, the TimeStamp API is awesome. Good idea.
Attachment #418287 -
Flags: review?(roc)
Attachment #418287 -
Flags: review?(roc) → review+
pushed to mozilla-central http://hg.mozilla.org/mozilla-central/rev/7b4a0ecd39ff
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•