Closed Bug 536101 Opened 15 years ago Closed 14 years ago

replace avmplus Legacy integer types with C99 types

Categories

(Tamarin Graveyard :: Virtual Machine, defect, P3)

Product:
Tamarin Graveyard
Component:
Virtual Machine
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Q3 11 - Serrano

People

(Reporter: edwsmith, Assigned: stejohns)

References

Details

Attachments

(1 file, 16 obsolete files)

Stamp out final holdouts, remove the definitions entirely
10.43 KB, patch
edwsmith
: review+
Details | Diff | Splinter Review
Some of the uses of legacy types have already been converted. This bug tracks the remaining uses. The plan is one patch per type replaced.
Target Milestone: --- → Future
Attached patch replace int64 with int64_t (obsolete) — — Splinter Review
Assignee: nobody → edwsmith
Attached patch replace sint64 with int64_t (obsolete) — — Splinter Review
Attached patch uint64 -> uint64_t (obsolete) — — Splinter Review
Attached patch uint32 -> uint32_t (obsolete) — — Splinter Review
Attached patch int32 -> int32_t (obsolete) — — Splinter Review
Attached patch sint32 -> int32_t (obsolete) — — Splinter Review
Attached patch uint16 -> uint16_t (obsolete) — — Splinter Review
Attached patch int16 -> int16_t (obsolete) — — Splinter Review
Attached patch sint16 -> int16_t (obsolete) — — Splinter Review
Attached patch uint8 -> uint8_t (obsolete) — — Splinter Review
Attached patch int8 -> int8_t (obsolete) — — Splinter Review
Attached patch uintptr -> uintptr_t (obsolete) — — Splinter Review
Attached patch sintptr -> intptr_t (obsolete) — — Splinter Review
Attached patch byte -> uint8_t (obsolete) — — Splinter Review
Attachment #418588 - Flags: review+
Attachment #418632 - Flags: review?(stejohns)
Attachment #418633 - Flags: review+
Attachment #418632 - Flags: review?(stejohns) → review+
Attachment #418653 - Flags: review+
Attachment #418650 - Flags: review+
Attachment #418647 - Flags: review+
Attachment #418645 - Flags: review+
Attachment #418644 - Flags: review+
Attachment #418642 - Flags: review+
Attachment #418588 - Attachment is obsolete: true
Comment on attachment 418632 [details] [diff] [review] replace sint64 with int64_t pushed http://hg.mozilla.org/tamarin-redux/rev/3b042c2577b7
Attachment #418632 - Attachment is obsolete: true
Comment on attachment 418633 [details] [diff] [review] uint64 -> uint64_t pushed http://hg.mozilla.org/tamarin-redux/rev/7563ce4913d7
Attachment #418633 - Attachment is obsolete: true
Blocks: 537926
Attachment #418642 - Attachment is obsolete: true
Comment on attachment 418644 [details] [diff] [review] uint16 -> uint16_t pushed http://hg.mozilla.org/tamarin-redux/rev/efccf4cc31b8
Attachment #418644 - Attachment is obsolete: true
Comment on attachment 418645 [details] [diff] [review] int16 -> int16_t pushed http://hg.mozilla.org/tamarin-redux/rev/9d5bbb0261f4
Attachment #418645 - Attachment is obsolete: true
Comment on attachment 418647 [details] [diff] [review] sint16 -> int16_t pushed http://hg.mozilla.org/tamarin-redux/rev/4f666dad578b
Attachment #418647 - Attachment is obsolete: true
Comment on attachment 418650 [details] [diff] [review] int8 -> int8_t pushed http://hg.mozilla.org/tamarin-redux/rev/d14a6476b1dc
Attachment #418650 - Attachment is obsolete: true
Comment on attachment 418653 [details] [diff] [review] sintptr -> intptr_t pushed
Attachment #418653 - Attachment is obsolete: true
Assignee: edwsmith → stejohns
Since this came up as an issue in a separate project, better to finish it once and for all.
Attachment #418651 - Attachment is obsolete: true
Attachment #448739 - Flags: review?(stejohns)
patch is consecutive: 1. uintptr_t 2. uint32_t
Attachment #418637 - Attachment is obsolete: true
Attachment #448747 - Flags: review?(stejohns)
Attachment #448739 - Flags: review?(stejohns) → review+
Comment on attachment 448739 [details] [diff] [review] (v2) Mechanical rename uintptr -> uintptr_t rubberstamping based on quick skim -- LMK if you want an in-depth review
Comment on attachment 448747 [details] [diff] [review] (v2) mechanical rename uint32 -> uint32_t rubberstamping based on quick skim -- LMK if you want an in-depth review
Attachment #448747 - Flags: review?(stejohns) → review+
rename was mechanical, and sandbox passed, IMO that's good enough. rubber stamp is not really useful, easier to just skip the review step for the next 3 types (uint8, int32, and byte)? i want to close out this bug this week if possible.
make it so
fwiw i noted a couple of reduncancies in the first patch where there were back-to-back AvmAsserts on the sizes of uintptr and uintptr_t; there are now two asserts for uintptr_t (for example).
i'll clean them up in the next patch
Also, I meant to leave the typedef's enabled, until we fixed FRR/avmglue. I will re-enable them (just uint32_t and uintptr_t) unless someone (stejohns?) wants to volunteer to quickly take care of FRR.
uintptr: http://hg.mozilla.org/tamarin-redux/rev/3ad6e2290fec uint32: http://hg.mozilla.org/tamarin-redux/rev/a8ecbbb5972a I looked again and could not find redundant AvmAsserts or STATIC_ASSERTS for uintptr_t, although its worth noting that both AvmCore.cpp and GC.cpp have a block of identical static asserts checking all these type sizes. we could remove the set in AvmCore.cpp.
int32, uint8, byte: http://hg.mozilla.org/tamarin-redux/rev/9f7d6c6b659a Only one step remaining: scrub FRR and then remove the legacy typedefs.
Priority: -- → P3
Target Milestone: Future → flash10.2
Attachment #418638 - Attachment is obsolete: true
Attachment #418649 - Attachment is obsolete: true
Attachment #418655 - Attachment is obsolete: true
Attachment #448739 - Attachment is obsolete: true
Attachment #448747 - Attachment is obsolete: true
Time to put this sucker to bed.
Attachment #477981 - Flags: review?(edwsmith)
Comment on attachment 477981 [details] [diff] [review] Stamp out final holdouts, remove the definitions entirely I had already stamped out the final holdouts once; these are ones that crept back in. the only holdup is cleaning up the player code. +100 to doing that ASAP.
Attachment #477981 - Flags: review?(edwsmith) → review+
pushed 5250:f145f4863f0f
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Flags: flashplayer-bug-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: