536209 - Update internal timezone database from version 2009p to version 2010i

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Stefan Sitter [:ssitter]]

Olson timezone database has been released in new version:

ftp://elsie.nci.nih.gov/pub/tzcode2009t.tar.gz
ftp://elsie.nci.nih.gov/pub/tzdata2009t.tar.gz

Comment 1

[Daniel Boelzle [:dbo]]

I just noticed that vzic 1.3 doesn't work any longer with the latest 2009u data. Since vzic doesn't seem to be supported any longer, we either need to fix it or look for an alternative way to generate iCalendar VTIMEZONEs.

Comment 2

[Stefan Sitter [:ssitter]]

Olson timezone database has been released in version 2010a:
ftp://elsie.nci.nih.gov/pub/tzdata2010a.tar.gz

Comment 3

[Stefan Sitter [:ssitter]]

Olson timezone database has been released in version 2010b:
ftp://elsie.nci.nih.gov/pub/tzdata2010b.tar.gz

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

We should find some way to automate this. The update script needs some interaction once in a while, maybe we can change it to read from a manifest file. In addition we could add a buildbot job that:
.
* Loads the latest timezones from the web. We might want/have to talk to nih.gov or mirrors since we would be doing a periodic download.

* Run the update script. If there is an unsolved situation, go orange/red.

* Build only the timezone extension.

Stefan, does this sound reasonable? If so, I'll file a new bug to investigate further.

Comment 5

[Stefan Sitter [:ssitter]]

Maybe we can store tzcode*.tar.gz or tzdata*.tar.gz or both or its content in our tree, similar to e.g. the libical or sqlite source files. The build process automatically creates the database file. But updating to a new tz release is done manually by creating a patch to ensure that it is controlled by us.

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

With the tzurl version of vzic, I was able to get a step further.

This is the patch for 2010i.

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: diff -U20 timezones_before_update.dump timezones.dump

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Changes needed for /home/kewisch/mozilla/comm-central/calendar/timezones/../../calendar/locales/en-US/chrome/calendar/timezones.properties:
---
add    pref.timezone.America.Matamoros=America/Matamoros
add    pref.timezone.America.Ojinaga=America/Ojinaga
add    pref.timezone.America.Santa_Isabel=America/Santa Isabel
add    pref.timezone.Antarctica.Macquarie=Antarctica/Macquarie
add    pref.timezone.Asia.Novokuznetsk=Asia/Novokuznetsk
---


timezone has been updated: Africa/Tunis
timezone has been updated: America/Argentina/San_Luis
timezone has been updated: America/Asuncion
timezone has been updated: America/Tijuana
timezone has been updated: Antarctica/Mawson
timezone has been updated: Asia/Anadyr
timezone has been updated: Asia/Damascus
timezone has been updated: Asia/Gaza
timezone has been updated: Asia/Kamchatka
timezone has been updated: Asia/Karachi
timezone has been updated: Europe/Samara
timezone: Pacific/Wallis    [t]ake over as is or use [a]lias? t


Changes needed for /home/kewisch/mozilla/comm-central/calendar/timezones/../../calendar/locales/en-US/chrome/calendar/timezones.properties:
---
---



DONE.

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

btw, this was the vzic output:

WARNING: Antarctica/Palmer: Modifying RRULE to be compatible with Outlook (day >= 9, month = 10)
WARNING: Antarctica/Palmer: Modifying RRULE to be compatible with Outlook (day >= 9, month = 3)
WARNING: Couldn't find a LETTER_S to use in FORMAT: CHO%sT in Zone: Asia/Choibalsan Leaving TZNAME empty
WARNING: America/Godthab: Modifying RRULE to be compatible with Outlook (day >= 24, month = 3)
WARNING: America/Godthab: Modifying RRULE to be compatible with Outlook (day >= 24, month = 10)
WARNING: Couldn't find a LETTER_S to use in FORMAT: M%sT in Zone: America/Inuvik Leaving TZNAME empty
WARNING: Couldn't find a LETTER_S to use in FORMAT: P%sT in Zone: America/Whitehorse Leaving TZNAME empty
WARNING: Couldn't find a LETTER_S to use in FORMAT: P%sT in Zone: America/Dawson Leaving TZNAME empty
WARNING: Couldn't find a LETTER_S to use in FORMAT: AR%sT in Zone: America/Argentina/San_Luis Leaving TZNAME empty
Skipping DAYLIGHT change
WARNING: America/Santiago: Modifying RRULE to be compatible with Outlook (day >= 9, month = 10)
WARNING: America/Santiago: Modifying RRULE to be compatible with Outlook (day >= 9, month = 3)

Comment 10

[Daniel Boelzle [:dbo]]

Comment on attachment 443847 [details] [diff] [review]
Fix - v1

- I'd prefer to group all addes ones at the end of the 
timezones.properties file, like "added with update to 2010i: ..."
- Please add a pointer to the tzurl vzic fork to the update instructions in timezones/Makefile.in.

r=dbo; looks good

Comment 11

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/85b6970f7084>
-> FIXED

Comment 12

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-1.9.2 <http://hg.mozilla.org/releases/comm-1.9.2/rev/ed4ca6cb5dfd>
-> FIXED