536346 - Keyboard shortcut in Menu Edit Selection should be Ctrl+A not Alt+A as shown

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[SamioSeven]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; it; rv:1.9.1.6) Gecko/20091201 Firefox/3.5.6
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; it; rv:1.9.1.5) Gecko/20091204 Thunderbird/3.0

In "Menu Edit Selection All" shortcut shown is Alt+A but Ctrl-A works instead (as expected). I don't know if it is a traslation error or so.

Reproducible: Always

Steps to Reproduce:
1.Select menu > edit > select > all (Alt+A is shown)
2.keyboard shortcut that actualy works: Ctrl+A (as expeted by documentation)
3.

Comment 1

[Ludovic Hirlimann [:Usul]]

(In reply to comment #0)
> User-Agent:       Mozilla/5.0 (X11; U; Linux i686; it; rv:1.9.1.6)
> Gecko/20091201 Firefox/3.5.6
> Build Identifier: Mozilla/5.0 (X11; U; Linux i686; it; rv:1.9.1.5)
> Gecko/20091204 Thunderbird/3.0
> 
> In "Menu Edit Selection All" shortcut shown is Alt+A but Ctrl-A works instead
> (as expected). I don't know if it is a traslation error or so.

What locale are you using ?

Comment 2

[SamioSeven]

> What locale are you using ?

Italian locale

Comment 3

[Ludovic Hirlimann [:Usul]]

Aureliano can you confirm , and move to localizaton/Italian if you see it too ?

Comment 4

[[:Aureliano Buendía]]

Attachment: screenshot

(In reply to comment #3)
> Aureliano can you confirm , and move to localizaton/Italian if you see it too ?

WFM 

Mozilla/5.0 (Windows; U; Windows NT 6.1; it; rv:1.9.1.5) Gecko/20091204 Lightning/1.1a1pre Thunderbird/3.0 ID:20091204171430

attached screenshot.

SamioSeven, do you use any extension?Have you tried in safe-mode?

Comment 5

[SamioSeven]

Attachment: Alt+A is shown instead of Ctrl+A

> attached screenshot.
> 
> SamioSeven, do you use any extension?Have you tried in safe-mode?

No extensions or Themes, I have a bare installation.
Running ./Thunderbird -safe-mode doesn't change anithing.

Attached screenshot of the bug.

Just in case, 

Happy Christmas to all of you :)

Comment 6

[[:Aureliano Buendía]]

ops... I'm sorry I make a test on Windows and not on Linux... I make a test on Linux later.

Comment 7

[[:Aureliano Buendía]]

Confirmed on Linux also in en-us locale.

But I think that this bug is Invalid because CTRL+A is default on Windows but ALT+A is default on Linux... or not?

Comment 8

[SamioSeven]

This is a list of the most common keyboard shortcuts in Thunderbird:

http://www.mozilla.org/support/thunderbird/keyboard

Comment 9

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Ctrl+a comes from browser-base.inc and Alt+a from platformHTMLBindings.xml. 

Evidently Ctrl+a hasn't been shown on linux because it's theoretically a linux shortcut for "go to start of line" which is not implemented in mozilla...

Anyway, i'd too prefer Ctrl+A as it's what's used in firefox, other applications, elsewhere in thunderbird (like in compose), and it's what most people would use.

Comment 10

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 419209 [details] [diff] [review]
proposed fix

Looks good to me

Comment 11

[Magnus Melin [:mkmelin]]

Attachment: proposed fix, v2

Unbitrotting. Carrying fwd ui-r=clarkbw

Comment 12

[Magnus Melin [:mkmelin]]

changeset:   5096:6d51010aa063
http://hg.mozilla.org/comm-central/rev/6d51010aa063

->FIXED