Closed Bug 536543 Opened 10 years ago Closed 10 years ago

Make getIndexOfFolder return a number, not a string

Categories

(Thunderbird :: Folder and Message Lists, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.1a1

People

(Reporter: rain1, Assigned: rain1)

References

Details

(Keywords: dev-doc-needed)

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
This is just a nasty bug lying in wait <http://mxr.mozilla.org/comm-central/source/mail/base/content/folderPane.js#710>.

For 3.0, I think that instead of changing the API we should convert the index there to a number before adding 1 to it.
Attachment #418993 - Flags: review?(bienvenu)
Assignee: nobody → sid.bugzilla
Status: NEW → ASSIGNED
I filed bug 536552 for Thunderbird 3.0.

The mozmill test here is the same as in bug 536552, and demonstrates at least one issue nicely.
Attachment #418993 - Attachment is obsolete: true
Attachment #419005 - Flags: review?(bienvenu)
Attachment #418993 - Flags: review?(bienvenu)
Attachment #419005 - Flags: review?(bienvenu) → review+
http://hg.mozilla.org/comm-central/rev/3b82a02cc4eb

This needs a combined dev doc for both itself (on trunk) and bug 536552 (on branch, once it lands). A way to test for the existence of a folder in the view that would be compatible with both branch and trunk is to test whether the returned index is non-null.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: dev-doc-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1a1
Flags: in-testsuite+
Blocks: 536042
You need to log in before you can comment on or make changes to this bug.