Make getIndexOfFolder return a number, not a string

RESOLVED FIXED in Thunderbird 3.1a1

Status

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: sid0, Assigned: sid0)

Tracking

({dev-doc-needed})

Trunk
Thunderbird 3.1a1
dev-doc-needed
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 418993 [details] [diff] [review]
patch

This is just a nasty bug lying in wait <http://mxr.mozilla.org/comm-central/source/mail/base/content/folderPane.js#710>.

For 3.0, I think that instead of changing the API we should convert the index there to a number before adding 1 to it.
Attachment #418993 - Flags: review?(bienvenu)
(Assignee)

Updated

9 years ago
Assignee: nobody → sid.bugzilla
Status: NEW → ASSIGNED
(Assignee)

Comment 1

9 years ago
Created attachment 419005 [details] [diff] [review]
patch + mozmill test

I filed bug 536552 for Thunderbird 3.0.

The mozmill test here is the same as in bug 536552, and demonstrates at least one issue nicely.
Attachment #418993 - Attachment is obsolete: true
Attachment #419005 - Flags: review?(bienvenu)
Attachment #418993 - Flags: review?(bienvenu)

Updated

9 years ago
Attachment #419005 - Flags: review?(bienvenu) → review+
(Assignee)

Comment 2

9 years ago
http://hg.mozilla.org/comm-central/rev/3b82a02cc4eb

This needs a combined dev doc for both itself (on trunk) and bug 536552 (on branch, once it lands). A way to test for the existence of a folder in the view that would be compatible with both branch and trunk is to test whether the returned index is non-null.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Keywords: dev-doc-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1a1
(Assignee)

Updated

9 years ago
Flags: in-testsuite+
(Assignee)

Updated

9 years ago
Blocks: 536042
You need to log in before you can comment on or make changes to this bug.