536848 - Plugin finder service resorts to manual install for Flash

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Plugins, defect)

Description

[Chris Ilias [:cilias]]

Here's a screencast: <http://screencast.com/t/NWI0ZDQ4Z>.

Using Build identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2b5) Gecko/20091204 Firefox/3.6b5 and Windows 7, the plugin finder service does not find Flash and resorts to a manual install.

Seems to work fine on 3.5.x. I haven't tested on trunk.
I also tried installing 3.6b5 in C:\Program Files\Mozilla Firefox\ and go prompted for a manual install.

Comment 1

[Michael Morgan [:morgamic]]

There's a regex for version since the installLocation support didn't start until 3.0+ and it's not recognizing 3.6.  Will post a patch.

Comment 2

[Michael Morgan [:morgamic]]

Attachment: v1, removes bad regex and obsolete fx2 tests

Comment 3

[Wil Clouser [:clouserw]]

Comment on attachment 420389 [details] [diff] [review]
v1, removes bad regex and obsolete fx2 tests

sure.  If that regex grows we should convert to something like 3\.[05]

Comment 4

[Michael Morgan [:morgamic]]

Thanks Wil - thought about that, but I'd rather have no regex than a different one and fx2 support is moot.

r59148

Comment 5

[Michael Morgan [:morgamic]]

This went to production.  If someone could verify that'd be awesome.

Comment 6

[[:Cww]]

Awesomesauce!