Add toggletoolbar="true" to the windows that should have a Mac toolbar toggle pill

RESOLVED FIXED in seamonkey2.1a3

Status

SeaMonkey
UI Design
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: stefanh, Assigned: stefanh)

Tracking

Trunk
seamonkey2.1a3
x86
Mac OS X

Firefox Tracking Flags

(blocking-seamonkey2.1 b1+)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
As philor said in bug #520338:

"After bug 269410, we need to add toggletoolbar="true" to the window element in windows where we want the pill button to toggle the toolbar...."

This is 1.9.2/1.9.3-only.
(Assignee)

Comment 1

7 years ago
I think we should have this on the radar, so it doesn't get lost.
blocking-seamonkey2.1: --- → ?
Target Milestone: seamonkey2.1a1 → ---
blocking-seamonkey2.1: ? → b1+
(Assignee)

Comment 2

7 years ago
Created attachment 458093 [details] [diff] [review]
Add pill button and remove top border

Re the css: the border is not needed anymore (mstange have fixed it). There are some problems, though - see bug 579250. I'll remove it anyway, since I think things will finally be solved:

<mstange>	roc will probably fix it again, so you might just remove it
Assignee: nobody → stefanh
Status: NEW → ASSIGNED
Attachment #458093 - Flags: superreview?(neil)
Attachment #458093 - Flags: review?(mnyromyr)
(Assignee)

Updated

7 years ago
Target Milestone: --- → seamonkey2.1a3

Comment 3

7 years ago
Comment on attachment 458093 [details] [diff] [review]
Add pill button and remove top border

You are allowed to add the attribute in the middle of the list on all the windows, thus avoiding editing the existing last line ;-)
Attachment #458093 - Attachment description: Add pil button and remove top border → Add pill button and remove top border
Attachment #458093 - Flags: superreview?(neil) → superreview+

Comment 4

7 years ago
Comment on attachment 458093 [details] [diff] [review]
Add pill button and remove top border

I wonder if the pill button maybe should also toggle the sidebar, like it does in the Finder?

r=me without the change noise Neil mentioned.
Attachment #458093 - Flags: review?(mnyromyr) → review+
(Assignee)

Comment 5

7 years ago
http://hg.mozilla.org/comm-central/rev/c08135ef6a07 (with fixed noise).
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

7 years ago
(In reply to comment #4)
> 
> I wonder if the pill button maybe should also toggle the sidebar, like it does
> in the Finder?

I think that would be an overkill :-)
You need to log in before you can comment on or make changes to this bug.