53712 - Changing themes shouldn't re-apply current theme

Status: VERIFIED FIXED

(Core Graveyard :: Skinability, defect, P3)

Description

[Kathleen :Brade]

If I have "Modern" theme selected and go to the menu and choose "Modern", the app 
pauses and loads Modern theme (even though it's already loaded).  This is kinda 
silly.  We should fix it some time.

Comment 1

[[e-mail]]

Actually this is convenient when developing skins - just reapply the skin.

Comment 2

[[e-mail]]

What would be nice is a radiomark on the selected skin.

Comment 3

[Blake Ross]

--> skinability

Comment 4

[Blake Ross]

.

Comment 5

[Blake Ross]

*** Bug 59890 has been marked as a duplicate of this bug. ***

Comment 6

[Jesse Ruderman]

I also disagree with this bug, because I like being able to re-apply Modern 
quickly when I run into a skinnability/theme bug.

Comment 7

[Matthew T (active 1999-2002)]

End users outnumber theme developers by a ratio of several million to one. So if 
there is a choice between end users wasting a few seconds by accidentally 
reapplying a theme which is already in effect, or developers wasting a few 
seconds by having to switch from Modern to Classic and back to Modern in order to 
test Modern bug-fixes, the interest of the end users should win easily. (I 
shouldn't have to be saying this.)

A radio mark for the selected theme, as mentioned by Neil, is bug 54681.

Comment 8

[Paul Chen]

Pretriage of skinnability bugs, marking nsbeta1-, no time to fix this for beta1

Comment 9

[Paul Chen]

Marking nsbeta1- bugs as future to get off the radar

Comment 10

[Gervase Markham [:gerv]]

Attachment: Patch - stops reapplication of current skin + disables Apply button

Comment 11

[Gervase Markham [:gerv]]

The amount of triage attention this bug has had, someone might as well have
fixed it :-) It's two lines, plus another two to disable the Apply button.

Once this is in, we can make themes apply on "OK." Let's see how friction-free
the r=, sr= process can be.

Any of blake, hewitt or ben could review this in 10 seconds flat. Guys?

Gerv

Comment 12

[timeless]

r=timeless
and once an outsider provides a patch, the triage is useless :)

Comment 13

[[e-mail]]

I assume that this only looks at your global skin, so that although Chatzilla
can only use its build-in Modern skin you can still (re-)apply Modern to Chatzilla.

Comment 14

[Gervase Markham [:gerv]]

<shrug> It asks the chrome registry. I have no idea what Chatzilla does :-)

Gerv

Comment 15

[timeless]

per app skin switching ui just isn't there, if you want to create a good ui for 
it please try, but expect for people to object to whatever ui you design :(

Comment 16

[Gervase Markham [:gerv]]

alecf: Could you sr= this, please?

Gerv

Comment 17

[Alec Flett]

sr=alecf

Comment 18

[Gervase Markham [:gerv]]

Checked in by bz - thanks :-)

Gerv

Comment 19

[Patty Mac]

Verified on Mac (commercial build: 2001-06-01-08-Trunk)

Comment 20

[Julien Cegarra]

Using Modern them and using View > Apply Themes > Mordern, will refresh the 
screen.

Build ID: 2002 01 16 04 !

possible regression?

/jc