537181 - Add required prefs and set proper config options to support app updating

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Reed Loden [:reed]]

Fennec on WinMo is going to start supporting app updating, and right now, mobile.js doesn't have any of the needed prefs for that. Need to add the necessary prefs.

However, since Maemo doesn't use AUS, need to ifdef things to ensure AUS isn't used for Maemo or any platform that doesn't need it.

Comment 1

[Reed Loden [:reed]]

confvars.sh has MOZ_UPDATER=0 now, so will need to change that, too...

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Our confvars.sh doesn't actually have any effect on the xulrunner build process, so that flag has no effect. We're currently disabling the updater in maemo builds in the releng mozconfigs:

https://hg.mozilla.org/build/buildbot-configs/file/68826f6f2a9f/mozilla2/linux/mobile-browser/nightly/mozconfig#l16

Comment 3

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #2)
> so that flag has no effect

filed bug 538021, fwiw.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

took these directly from firefox.js.

Note that we'll need the patch on bug bug 538021 for this to have any effect.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #4)
> Note that we'll need the patch on bug bug 538021 for this to have any effect.

Not really, that patch is just cleanup - that setting is currently being ignored.

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch v.2

swapped out product name for app id and added the gre version

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 421894 [details] [diff] [review]
patch v.2

missing some "app.update.*" prefs in firefox-branding.js

Add them inside a #ifdef MOZ_OFFICIAL_BRANDING that is inside #ifdef MOZ_UPDATER

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch v.3

Comment 9

[Reed Loden [:reed]]

Comment on attachment 421917 [details] [diff] [review]
patch v.3

>+pref("app.update.url", "https://aus2.mozilla.org/update/3/%APP_ID%/%VERSION%/%GRE_MILESTONE%/%BUILD_ID%/%BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/update.xml");

%APP_ID% without incrementing storage directory is probably not ok... Need bug 540007 fixed.

>+pref("app.update.url.manual", "http://www.mozilla.com/m");

http://www.mozilla.com/%LOCALE%/m/, please.

>+pref("app.update.url.details", "http://www.mozilla.com/%LOCALE%/%APP%/releases/");

Replace %APP% with "mobile".

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #9)
> (From update of attachment 421917 [details] [diff] [review])
> >+pref("app.update.url", "https://aus2.mozilla.org/update/3/%APP_ID%/%VERSION%/%GRE_MILESTONE%/%BUILD_ID%/%BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/update.xml");
> 
> %APP_ID% without incrementing storage directory is probably not ok... Need bug
> 540007 fixed.

Not sure what reed's talking about here, but he's probably on to something

> >+pref("app.update.url.manual", "http://www.mozilla.com/m");
> 
> http://www.mozilla.com/%LOCALE%/m/, please.

We redirect there anyway, so make the change to save us the redirect - and remember the trailing slash

> >+pref("app.update.url.details", "http://www.mozilla.com/%LOCALE%/%APP%/releases/");
> 
> Replace %APP% with "mobile".

Agreed

Comment 11

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch v.4

(In reply to comment #10)
> (In reply to comment #9)
> > (From update of attachment 421917 [details] [diff] [review] [details])
> > >+pref("app.update.url", "https://aus2.mozilla.org/update/3/%APP_ID%/%VERSION%/%GRE_MILESTONE%/%BUILD_ID%/%BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/update.xml");
> > 
> > %APP_ID% without incrementing storage directory is probably not ok... Need bug
> > 540007 fixed.
> 
> Not sure what reed's talking about here, but he's probably on to something

neither do I. Bug 540007 is marked as a blocker for this bug already.

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 422542 [details] [diff] [review]
patch v.4


>+#ifdef MOZ_OFFICIAL_BRANDING
>+pref("app.update.interval", 86400);
>+pref("app.update.download.backgroundInterval", 600);
>+pref("app.update.url.manual", "http://www.mozilla.com/%LOCALE%/m/");
>+pref("app.update.url.details", "http://www.mozilla.com/%LOCALE%/mobile/releases/");
>+#else 
>+pref("app.update.interval", 21600);

FF uses 28800 (8hours) for nightlies. Let's match them.

Comment 13

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mobile-browser/rev/0f1676f43e39