Closed Bug 537181 Opened 10 years ago Closed 10 years ago

Add required prefs and set proper config options to support app updating

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: reed, Assigned: blassey)

References

(Depends on 1 open bug)

Details

Attachments

(1 file, 3 obsolete files)

Fennec on WinMo is going to start supporting app updating, and right now, mobile.js doesn't have any of the needed prefs for that. Need to add the necessary prefs.

However, since Maemo doesn't use AUS, need to ifdef things to ensure AUS isn't used for Maemo or any platform that doesn't need it.
confvars.sh has MOZ_UPDATER=0 now, so will need to change that, too...
Summary: Add required app.update.* prefs to support app updating → Add required prefs and set proper config options to support app updating
Our confvars.sh doesn't actually have any effect on the xulrunner build process, so that flag has no effect. We're currently disabling the updater in maemo builds in the releng mozconfigs:

https://hg.mozilla.org/build/buildbot-configs/file/68826f6f2a9f/mozilla2/linux/mobile-browser/nightly/mozconfig#l16
(In reply to comment #2)
> so that flag has no effect

filed bug 538021, fwiw.
Attached patch patch (obsolete) — Splinter Review
took these directly from firefox.js.

Note that we'll need the patch on bug bug 538021 for this to have any effect.
Assignee: nobody → bugmail
Attachment #421482 - Flags: review?
Attachment #421482 - Flags: review? → review?(gavin.sharp)
(In reply to comment #4)
> Note that we'll need the patch on bug bug 538021 for this to have any effect.

Not really, that patch is just cleanup - that setting is currently being ignored.
Attached patch patch v.2 (obsolete) — Splinter Review
swapped out product name for app id and added the gre version
Attachment #421482 - Attachment is obsolete: true
Attachment #421894 - Flags: review?(mark.finkle)
Attachment #421482 - Flags: review?(gavin.sharp)
See Also: → 540007
Attachment #421894 - Attachment is patch: true
Attachment #421894 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 421894 [details] [diff] [review]
patch v.2

missing some "app.update.*" prefs in firefox-branding.js

Add them inside a #ifdef MOZ_OFFICIAL_BRANDING that is inside #ifdef MOZ_UPDATER
Attachment #421894 - Flags: review?(mark.finkle) → review-
Attached patch patch v.3 (obsolete) — Splinter Review
Attachment #421894 - Attachment is obsolete: true
Attachment #421917 - Flags: review?(mark.finkle)
Comment on attachment 421917 [details] [diff] [review]
patch v.3

>+pref("app.update.url", "https://aus2.mozilla.org/update/3/%APP_ID%/%VERSION%/%GRE_MILESTONE%/%BUILD_ID%/%BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/update.xml");

%APP_ID% without incrementing storage directory is probably not ok... Need bug 540007 fixed.

>+pref("app.update.url.manual", "http://www.mozilla.com/m");

http://www.mozilla.com/%LOCALE%/m/, please.

>+pref("app.update.url.details", "http://www.mozilla.com/%LOCALE%/%APP%/releases/");

Replace %APP% with "mobile".
Attachment #421917 - Flags: review-
Depends on: 540007
(In reply to comment #9)
> (From update of attachment 421917 [details] [diff] [review])
> >+pref("app.update.url", "https://aus2.mozilla.org/update/3/%APP_ID%/%VERSION%/%GRE_MILESTONE%/%BUILD_ID%/%BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/update.xml");
> 
> %APP_ID% without incrementing storage directory is probably not ok... Need bug
> 540007 fixed.

Not sure what reed's talking about here, but he's probably on to something

> >+pref("app.update.url.manual", "http://www.mozilla.com/m");
> 
> http://www.mozilla.com/%LOCALE%/m/, please.

We redirect there anyway, so make the change to save us the redirect - and remember the trailing slash

> >+pref("app.update.url.details", "http://www.mozilla.com/%LOCALE%/%APP%/releases/");
> 
> Replace %APP% with "mobile".

Agreed
Attached patch patch v.4Splinter Review
(In reply to comment #10)
> (In reply to comment #9)
> > (From update of attachment 421917 [details] [diff] [review] [details])
> > >+pref("app.update.url", "https://aus2.mozilla.org/update/3/%APP_ID%/%VERSION%/%GRE_MILESTONE%/%BUILD_ID%/%BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/update.xml");
> > 
> > %APP_ID% without incrementing storage directory is probably not ok... Need bug
> > 540007 fixed.
> 
> Not sure what reed's talking about here, but he's probably on to something

neither do I. Bug 540007 is marked as a blocker for this bug already.
Attachment #421917 - Attachment is obsolete: true
Attachment #422542 - Flags: review?(mark.finkle)
Attachment #421917 - Flags: review?(mark.finkle)
Comment on attachment 422542 [details] [diff] [review]
patch v.4


>+#ifdef MOZ_OFFICIAL_BRANDING
>+pref("app.update.interval", 86400);
>+pref("app.update.download.backgroundInterval", 600);
>+pref("app.update.url.manual", "http://www.mozilla.com/%LOCALE%/m/");
>+pref("app.update.url.details", "http://www.mozilla.com/%LOCALE%/mobile/releases/");
>+#else 
>+pref("app.update.interval", 21600);

FF uses 28800 (8hours) for nightlies. Let's match them.
Attachment #422542 - Flags: review?(mark.finkle) → review+
pushed http://hg.mozilla.org/mobile-browser/rev/0f1676f43e39
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.