540007 - AUS should use GUIDs instead of product names

Status: RESOLVED INCOMPLETE

(AUS Graveyard :: API, defect)

Description

[Michael Morgan [:morgamic]]

Right now the top-level identifier for any AUS product is the %PRODUCT% var in app.update.url.  This causes problems between Firefox and Fennec, since they essentially have the same %PRODUCT% name.

Blocklist, extension updates and other services key off of GUIDs since they are guaranteed to be unique.  AUS should follow suit, but this requires some changes for the web service and the build system:

1) URL schema should be incremented
2) Storage directory should be incremented (adding a "4")
3) Future updates (.mars, etc.) should be placed in 4/* with the first directory being the GUID instead of the product name
4) Throttling and throttle exceptions would have to use GUIDs (which sounds like a huge pain in the ass, but it'd be bad to have conflicting rules across desktop & mobile)

Comment 1

[Michael Morgan [:morgamic]]

Note - we could avoid a lot of trouble if we just added the Fennec GUID as a new product name instead.  If we were to do that, though, I'd prefer that we move other products to using GUIDs at some point to be consistent -- although it isn't entirely necessary, it'd feel better to do things the same way across the board.

Comment 2

[Justin Fitzhugh]

do we have an eta on this?  blocks 507024

Comment 3

[Michael Morgan [:morgamic]]

If we go with the option in comment #1, it could be done pretty quickly on the build side without any code changes.

Comment 4

[Justin Fitzhugh]

great - coop, will that unblock winmo nightly updates?

Comment 5

[Michael Morgan [:morgamic]]

(we could skip changing anything else for now)

Comment 6

[Chris Cooper [:coop] (he/him)]

(In reply to comment #4)
> great - coop, will that unblock winmo nightly updates?

It would unblock this particular part of WinMo nightly updates. There are still 2 other blockers outstanding in bug 507024.

Comment 7

[Chris Cooper [:coop] (he/him)]

(In reply to comment #3)
> If we go with the option in comment #1, it could be done pretty quickly on the
> build side without any code changes.

Mike: did you see https://bugzilla.mozilla.org/show_bug.cgi?id=537314#c3 ? 

Does that influence our options here, given that Fennec still makes no version distinction between branches?

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

Fennec provides the product version number and the gre milestone in the update url.

Comment 9

[Michael Morgan [:morgamic]]

Product name and platform are both directory names in the AUS2 data store -- instead of Firefox you'd use GUID and instead of a platform like WINNT_x86-msvc you'd use whatever represents WinMo.  Right?

Comment 10

[Michael Morgan [:morgamic]]

For example, this path:
/3/Firefox/3.6/WINCE_arm-msvc

For mobile it'd be (I think):
/3/%APP_ID%/1.0/%OS_VERSION%

Comment 11

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Can we close this as DUP/WONTFIX - it looks like this bug has been superseded by work in bug#546695?

Comment 12

[Brad Lassey [:blassey] (use needinfo?)]

my understanding is that this is still a good thing to do, it is no longer blocking fennec doing updates though

Comment 13

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

(In reply to comment #12)
> my understanding is that this is still a good thing to do, it is no longer
> blocking fennec doing updates though

Bug dependency fixed.

Comment 15

[Takanori MATSUURA]

This bug lies at rest in the graveyard.