Closed Bug 537290 Opened 10 years ago Closed 10 years ago
Reduce uses of a
Node .local Name, namespace URI in XPath generation
These hit "various XPConnect slow paths due to the cross-origin access" - bz in bug 536910 comment #29 We access these each iteration in a loop (counting sibling nodes) and once before even getting in the loop. We can take bring that down to 1 total per node (I don't think we can get rid accessing these in the sibling nodes).
I didn't move the assignment of nName up because we don't need to access it if the node has an ID, so it wasn't worth moving it up for slightly better looking code.
Attachment #419587 - Flags: review?(zeniko)
FWIW, Boris profiled with the test case in bug 536910 after this patch. We dropped from 24000 samples to 17500 samples (which is ~27% (or .11 seconds) savings).
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
10 years ago
Target Milestone: --- → Firefox 3.7a1
What can QA do to verify this bug?
If things didn't break, we're good.
(In reply to comment #5) > If things didn't break, we're good. Good enough! Marking verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.