Closed
Bug 537290
Opened 16 years ago
Closed 16 years ago
Reduce uses of aNode.localName, namespaceURI in XPath generation
Categories
(Firefox :: Session Restore, defect)
Firefox
Session Restore
Tracking
()
VERIFIED
FIXED
Firefox 3.7a1
People
(Reporter: zpao, Assigned: zpao)
References
(Blocks 1 open bug)
Details
(Whiteboard: [tsnap])
Attachments
(1 file)
|
1.95 KB,
patch
|
zeniko
:
review+
|
Details | Diff | Splinter Review |
These hit "various XPConnect slow paths due to the cross-origin access" - bz in bug 536910 comment #29
We access these each iteration in a loop (counting sibling nodes) and once before even getting in the loop. We can take bring that down to 1 total per node (I don't think we can get rid accessing these in the sibling nodes).
|
Assignee | |
Comment 1•16 years ago
|
||
I didn't move the assignment of nName up because we don't need to access it if the node has an ID, so it wasn't worth moving it up for slightly better looking code.
Attachment #419587 -
Flags: review?(zeniko)
|
||
Updated•16 years ago
|
Attachment #419587 -
Flags: review?(zeniko) → review+
|
|
Assignee | |
Comment 2•16 years ago
|
||
FWIW, Boris profiled with the test case in bug 536910 after this patch. We dropped from 24000 samples to 17500 samples (which is ~27% (or .11 seconds) savings).
|
|
Assignee | |
Comment 3•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•16 years ago
|
Target Milestone: --- → Firefox 3.7a1
|
|
Assignee | |
Comment 5•15 years ago
|
||
If things didn't break, we're good.
(In reply to comment #5)
> If things didn't break, we're good.
Good enough! Marking verified.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•