Closed Bug 537342 Opened 16 years ago Closed 1 year ago

Unified folders marked as favorites are not persisted

Categories

(Thunderbird :: Folder and Message Lists, defect)

x86
All
defect

Tracking

(thunderbird_esr128? affected, thunderbird134 wontfix, thunderbird135 affected)

RESOLVED FIXED
136 Branch
Tracking Status
thunderbird_esr128 ? affected
thunderbird134 --- wontfix
thunderbird135 --- affected

People

(Reporter: yuslep-mozilla, Assigned: welpy-cw)

References

Details

Attachments

(1 external file)

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.6) Gecko/20091201 Firefox/3.5.6 (.NET CLR 3.5.30729) Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.5) Gecko/20091204 Thunderbird/3.0 Marking smart folder as favorite does not show it among favorite folders Reproducible: Always Steps to Reproduce: - Go to Smart Folders list 1. Select one of the smart folders like Inbox/Trash/Sent etc. 2. Right click to display context menu 3. Select Favorite Folder 4. Switch to Favorite Folders list 5. Observe your newly favored folder absent Actual Results: Favorite smart folders not displayed under favorite folders list. Expected Results: Expect All of the Favorite Folders including smart folders to appear in favorite folders list.
should a smart folder even offer favorite?
Version: unspecified → 3.0
If it's not going to work, no, but I think it's possible to make it work by making the favorites generator also look at the smart folders account, which is hidden by default.
Status: UNCONFIRMED → NEW
Ever confirmed: true
I'd like to add a +1 to this. The smart folder concept is a great idea and makes managing several inboxes easy. I like my favorites because then I have a single view that has my rss feeds, various news groups that I subscribe to (that go into their own folders) and if I have the ability to add my smart inbox to my favorites, a single view to my inbox all from my favorites view.
=> minor given there is workaround
Severity: normal → minor
Status: NEW → UNCONFIRMED
Ever confirmed: false
=> UNCO was accidental. fixing
Status: UNCONFIRMED → NEW
Ever confirmed: true
Do you mean there is a workaround to having a smartfolder and favorites view?
the workaround is to mark a folder fav from some other view, eg All folders. admittedly unhandy, but should not be excessively so given the infrequency of needing to mark favs
OS: Windows XP → All
Summary: Marking smart folder as favorite does not show it among favorite folders → Marking unified folder as favorite does not show it among favorite folders
Just trying to understand the workaround, there is not a unified inbox view within all folders, just separate inboxes for each account. Hence it is not possible to add unified inbox to Favourite Folders from that view.
The reverse request, is bug 491440 - Smart folders - add Favorites
Seems to be a misunderstanding. There is no workaround I can see to making a unified Inbox appear on my favorites. Individual inboxes yes, but not a unified one.
This bug is mismatch among: (a) Design/Implementation of "Unified FOLDER VIEW"(different family from All FOLDER VIEW) and "Favarite FOLDER VIEW"(extended from All FOLDER VIEW). (b) UI to set folder attribute or property of "Favarite folder". ("Favarite" flag of folder flags) (c) User's expectation. Because "Unified FOLDER VIEW" shows hidden Search Folder only(Virtual Folder) which is internally defined under hidden account, "Unified FOLDER VIEW" is not affected by Favarite folder setting at any place. Because "Favarite FOLDER VIEW" shows only "folder set as Favarite folder at All FOLDER VIEW family", Unified folder defined in hidden special account is never accessed by "Favarite FOLDER VIEW". Simplest solution to avoid confusion. Disable "Favarite Folder" context menu if Unified Folder. (Unfied Folder : Inbox, Sent etc. at Unified folder View) Note: Each folder of "account name under Inbox, Sent at Unified foler view" is actual folder which is shown at All Folder view. Possible workaround by user: Create Search Folder(Virtual Folder) at All FOLDER VIEW with same definition as Unified Folder named Inbox, Sent etc., and set the Search Folder as "Favarite Folder". Bug opener, does it work? If it works, following is perhaps possible. Include Unified folder(a Saved Search folder) of hidden account in Favarite Folder View if Favarite flag is set, with protecting Unified folder's property from modification by user. Problem in implemetation of this; Unified folder defined under hidden account is invisible from Folder tree view of "Favarite Folder View". Unified folder should be searched from all account defintions always.
(In reply to WADA from comment #11) > This bug is mismatch among: > (a) Design/Implementation of "Unified FOLDER VIEW"(different family from All > FOLDER VIEW) and "Favarite FOLDER VIEW"(extended from All FOLDER VIEW). > (b) UI to set folder attribute or property of "Favarite folder". > ("Favarite" flag of folder flags) > (c) User's expectation. > > Because "Unified FOLDER VIEW" shows hidden Search Folder only(Virtual > Folder) which is internally defined under hidden account, "Unified FOLDER > VIEW" is not affected by Favarite folder setting at any place. > Because "Favarite FOLDER VIEW" shows only "folder set as Favarite folder at > All FOLDER VIEW family", Unified folder defined in hidden special account is > never accessed by "Favarite FOLDER VIEW". > > Simplest solution to avoid confusion. > Disable "Favarite Folder" context menu if Unified Folder. > (Unfied Folder : Inbox, Sent etc. at Unified folder View) > Note: Each folder of "account name under Inbox, Sent at Unified foler view" > is actual folder which is shown at All Folder view. > > Possible workaround by user: > Create Search Folder(Virtual Folder) at All FOLDER VIEW > with same definition as Unified Folder named Inbox, Sent etc., > and set the Search Folder as "Favarite Folder". > Bug opener, does it work? > > If it works, following is perhaps possible. > Include Unified folder(a Saved Search folder) of hidden account > in Favarite Folder View if Favarite flag is set, > with protecting Unified folder's property from modification by user. > Problem in implemetation of this; > Unified folder defined under hidden account is invisible > from Folder tree view of "Favarite Folder View". > Unified folder should be searched from all account defintions always. dmitri, do you still see this?
Flags: needinfo?(yuslep-mozilla)
Flags: needinfo?(yuslep-mozilla)
Severity: minor → S3

Thanks for sorting 1173577, Wayne, these few bugs sound all quite similar and I missed the details.

Personally, I'm not sure marking a unified folder as favorite makes sense.

My use case would be showing the Unified Inbox, which I find very useful, and hiding the rest of the Unified folders, which take up a good amount of space and I never use. If this bug weren't around, I would probably have a setup similar to how Mail works on iOS:

Favourites

  • Unified Inbox
  • Inbox A
  • Inbox B
  • Inbox C

All Folders

  • Account A
  • Account B
  • Account C

The unified inbox acts as a to-do list, followed by each account inbox for easy access. The All Folders cover all other cases.

I experience something similar which I think might be related to this. I also have my Unified Inbox marked as favorite folder and it shows up correctly in the Favorite Folders section of the sidebar. However, when I close and reopen Thunderbird, it is absent. When I then right-click the Unified Inbox in the Unified Folders section, the option Favorite Folder is still checked. Unchecking and re-checking it makes the Unified Inbox reappear under Favorites, until i close/reopen Thunderbird the next time. This also happens when restarting the computer.

I have the same experience as Niklas and am using and expecting the behaviour that dreadanaut identifies. The slight difference I'm seeing is that when Inbox - Unified is marked as a Favourite it can also just "drop off" if I leave Thunderbird open. If I go back to marking it as a Favourite folder again, it is still marked as a favourite so I have to deseelct and reselect and it appears back in the Favourite Folders section.

This feature is very useful as per dreadnaut's comments it allows to save screen real estate and remove "noise" from the panel.

(In reply to andrew from comment #15)

I have the same experience as Niklas and am using and expecting the behaviour that dreadanaut identifies. The slight difference I'm seeing is that when Inbox - Unified is marked as a Favourite it can also just "drop off" if I leave Thunderbird open. If I go back to marking it as a Favourite folder again, it is still marked as a favourite so I have to deseelct and reselect and it appears back in the Favourite Folders section.

This feature is very useful as per dreadnaut's comments it allows to save screen real estate and remove "noise" from the panel.

I've discovered how to replicate the behaviour. Go to View > Folders and untick Favourite Folders then repeat to select Favourite Folders again Unified Folders will not be in the list.

Couldn't find anything that directly occurred in the error console that maybe related.

Appears that the Unified Folders aren't included when Favourite Folders gets built.

(In reply to andrew from comment #16)

(In reply to andrew from comment #15)

I have the same experience as Niklas and am using and expecting the behaviour that dreadanaut identifies. The slight difference I'm seeing is that when Inbox - Unified is marked as a Favourite it can also just "drop off" if I leave Thunderbird open. If I go back to marking it as a Favourite folder again, it is still marked as a favourite so I have to deseelct and reselect and it appears back in the Favourite Folders section.

This feature is very useful as per dreadnaut's comments it allows to save screen real estate and remove "noise" from the panel.

I've discovered how to replicate the behaviour. Go to View > Folders and untick Favourite Folders then repeat to select Favourite Folders again Unified Folders will not be in the list.

Couldn't find anything that directly occurred in the error console that maybe related.

Appears that the Unified Folders aren't included when Favourite Folders gets built.

Found that this issue has been fixed in Betterbird, so if you are experiencing this and it's an issue for you, check Betterbird out.

(In reply to andrew from comment #17)

Found that this issue has been fixed in Betterbird, so if you are experiencing this and it's an issue for you, check Betterbird out.

Neat discovery, thank you! The patch they've applied looks [deceptively?] simple. Maybe it can be of inspiration for the Thunderbird team:

https://github.com/Betterbird/thunderbird-patches/blob/main/115/features/feature-537342-unified-as-favourite.patch

(licence: MPL v2)

Hello folks,
I have tested the BetterBird patch with Thunderbird 128.5.2, following these steps:

  • close Thunderbird
  • found omni.ja in the Thunderbird directory
  • made a backup copy
  • renamed the file to omni.zip
  • edited chrome/messenger/content/messenger/about3Pane.js inside the zip file, adding the lines from the patch
  • renamed to omni.ja
  • start Thunderbird

Thunderbird now seems to behave as expected, with "Inbox - Unified Folders" appearing at the top of the "Favourite Folders" section of the folder pane.

Anything we can do to help get this reviewed and included in a future release?

Thank you!
Fran

Summary: Marking unified folder as favorite does not show it among favorite folders → Unified folders marked as favorites are not persisted
Assignee: nobody → h.w.forms
Status: NEW → ASSIGNED
Target Milestone: --- → 136 Branch

Pushed by arschmitz@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/539f73c802a6
Add unified folders when favourite folders are built. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Duplicate of this bug: 1949070
Duplicate of this bug: 706536
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: