Don't ship dictionaries with language packs

RESOLVED FIXED in seamonkey2.1a1

Status

SeaMonkey
Build Config
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Robert Kaiser, Assigned: Robert Kaiser)

Tracking

({fixed-seamonkey2.0.3})

unspecified
seamonkey2.1a1
fixed-seamonkey2.0.3

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
SeaMonkey currently ship dictionaries with language packs but unfortunately, the licensing story there is somewhat unclear and it's probably not optimal to lose a selected dictionary when switching locales, so it's best to follow what Firefox and Thunderbird are doing and just exclude dictionaries from SeaMonkey builds.
(Assignee)

Updated

7 years ago
Flags: blocking-seamonkey2.0.2?
(Assignee)

Comment 1

7 years ago
Created attachment 419767 [details] [diff] [review]
don't include dictionaries in langpacks

This should be it. I don't have a locale around that builds and/or has a dictionary right now, so I can't test it atm, but normal build is not broken and this should be trivial.

Axel, there's nothing else where we should refer to this, right?
Attachment #419767 - Flags: review?(l10n)
Comment on attachment 419767 [details] [diff] [review]
don't include dictionaries in langpacks

The clobber-zip piece should stay, otherwise you're breaking the dictionaries for the binary builds.

I guess the trailing ';' can go, too.

Compare with the target in l10n.mk, http://mxr.mozilla.org/mozilla-central/source/toolkit/locales/l10n.mk#175

The only difference should be the searchplugins there.
Attachment #419767 - Flags: review?(l10n) → review-
(Assignee)

Comment 3

7 years ago
Created attachment 419781 [details] [diff] [review]
v2 - fully sync with what Firefox does

Thanks for looking at this, Axel. I actually think our searchplugins don't even work from an extension, so it's probably better to not package them as well and only have stuff in there that actually works (i.e. chrome only).

With that, the new patch should fully sync our langpacks to those Firefox ships (and make conversion to l10n.mk easier in the future).
Attachment #419767 - Attachment is obsolete: true
Attachment #419781 - Flags: review?(l10n)
Comment on attachment 419781 [details] [diff] [review]
v2 - fully sync with what Firefox does

Sounds good.
Attachment #419781 - Flags: review?(l10n) → review+
(Assignee)

Updated

7 years ago
Attachment #419781 - Flags: approval-seamonkey2.0.2?
(Assignee)

Comment 5

7 years ago
Pushed on trunk as http://hg.mozilla.org/comm-central/rev/d8bdb40b098a
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a1

Updated

7 years ago
Attachment #419781 - Flags: approval-seamonkey2.0.3? → approval-seamonkey2.0.3+
(Assignee)

Comment 6

7 years ago
Pushed on branch as http://hg.mozilla.org/releases/comm-1.9.1/rev/eeb567bb0464
Flags: blocking-seamonkey2.0.3?
Keywords: fixed-seamonkey2.0.3
You need to log in before you can comment on or make changes to this bug.