Closed
Bug 537742
Opened 14 years ago
Closed 14 years ago
disable plugins by default on the n810
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(fennec1.0+)
VERIFIED
FIXED
Tracking | Status | |
---|---|---|
fennec | 1.0+ | --- |
People
(Reporter: jmaher, Assigned: dougt)
Details
Attachments
(2 files, 2 obsolete files)
4.58 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
741 bytes,
patch
|
Details | Diff | Splinter Review |
I have noticed bug 537099 seems to be related to flash only on the n810. Also viewing youtube videos on the n810 the frame rate is very low (~4-6) vs something useful on the n900. Even the audio is jumpy on the n810 for flash video.
Assignee | ||
Comment 1•14 years ago
|
||
Assignee: nobody → mozbugz
Attachment #419979 -
Flags: superreview?
Attachment #419979 -
Flags: review?
Assignee | ||
Updated•14 years ago
|
Attachment #419979 -
Flags: review? → review?(mark.finkle)
Assignee | ||
Updated•14 years ago
|
Attachment #419979 -
Flags: superreview?
Assignee | ||
Comment 2•14 years ago
|
||
i probably need to add a "this.setPluginState(true);" Its 2010 and plugins.enabled still doesn't do a damn thing.
Assignee | ||
Comment 3•14 years ago
|
||
we can get rid of the preference by adding a "run once" callback here: http://mxr.mozilla.org/mobile-browser/source/chrome/content/browser.js#545 put "Util.needHomepageOverride()" into a local, and test for "new profile".
Assignee | ||
Comment 4•14 years ago
|
||
Attachment #419979 -
Attachment is obsolete: true
Attachment #420121 -
Flags: review?(mark.finkle)
Attachment #419979 -
Flags: review?(mark.finkle)
Updated•14 years ago
|
Attachment #420121 -
Flags: review?(mark.finkle) → review-
Comment 5•14 years ago
|
||
Comment on attachment 420121 [details] [diff] [review] patch v.2 Moving the tile cache stuff won't work. The BrowserView is created at the top of Browser.startup and the constructor calls BrowserView.init, which sets the cache size. Your code is setting the tile.cache.size preference at the bottom of Browser.startup - which is too late.
Assignee | ||
Comment 6•14 years ago
|
||
i'd like to keep these prefs-reset-based-on-device-type in the same place. should I move initNewProfile to the start of Browser.startup?
Assignee | ||
Comment 7•14 years ago
|
||
Attachment #420121 -
Attachment is obsolete: true
Comment 8•14 years ago
|
||
Comment on attachment 420156 [details] [diff] [review] patch v.3 > // Command line arguments/initial homepage > let whereURI = "about:blank"; >- switch (Util.needHomepageOverride()) { >+ >+ switch (needOverride) { Remove the blank line
Attachment #420156 -
Flags: review+
Updated•14 years ago
|
tracking-fennec: --- → 1.0+
Assignee | ||
Comment 9•14 years ago
|
||
http://hg.mozilla.org/mobile-browser/rev/3c75260a9b45
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 10•14 years ago
|
||
verified FIXED on builds: Mozilla/5.0 (X11; Linux armv7l; en-US; rv:1.9.2) Gecko/20100105 Firefox/3.6 Fennec/1.0 and Mozilla/5.0 (X11; Linux armv6l; en-US; rv:1.9.2) Gecko/20100105 Firefox/3.6 Fennec/1.0
Status: RESOLVED → VERIFIED
Flags: in-litmus?
Comment 11•14 years ago
|
||
Comment on attachment 420156 [details] [diff] [review] patch v.3 >diff --git a/chrome/content/browser.js b/chrome/content/browser.js >+ initNewProfile: function initNewProfile() { >+#ifdef MOZ_PLATFORM_HILDON >+ // The flash plugin on the n8xx doesn't support the image expose fast >+ // drawing we are doing. Disable all plugins by default. Users can override >+ // in prefs >+ if (device == "Nokia N8xx") { >+ gPrefService.setBoolPref("plugins.enabled", false); >+ this.setPluginState(true); This doesn't look right, setPluginState(true) enables all plugins...
Assignee | ||
Comment 12•14 years ago
|
||
yes. we need to flip the flag.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 13•14 years ago
|
||
when I was testing this, i only verified that the UI changed. :( To verify, you must load youtube.com or similar site and ensure that you see no flash content.
Assignee | ||
Comment 14•14 years ago
|
||
http://hg.mozilla.org/mobile-browser/rev/ad500c60b355
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Comment 15•14 years ago
|
||
verified FIXED on build: Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.2) Gecko/20100111 Firefox/3.6pre Fennec/1.1a1pre
Status: RESOLVED → VERIFIED
Assignee | ||
Updated•14 years ago
|
Component: Linux/Maemo → General
QA Contact: maemo-linux → general
Updated•14 years ago
|
Flags: in-litmus? → in-litmus-
You need to log in
before you can comment on or make changes to this bug.
Description
•