Closed Bug 537742 Opened 14 years ago Closed 14 years ago

disable plugins by default on the n810

Categories

(Firefox for Android Graveyard :: General, defect)

Fennec 1.1
ARM
Maemo
defect
Not set
normal

Tracking

(fennec1.0+)

VERIFIED FIXED
Tracking Status
fennec 1.0+ ---

People

(Reporter: jmaher, Assigned: dougt)

Details

Attachments

(2 files, 2 obsolete files)

I have noticed bug 537099 seems to be related to flash only on the n810.  Also viewing youtube videos on the n810 the frame rate is very low (~4-6) vs something useful on the n900.  Even the audio is jumpy on the n810 for flash video.
Attached patch patch v.1 (obsolete) — Splinter Review
Assignee: nobody → mozbugz
Attachment #419979 - Flags: superreview?
Attachment #419979 - Flags: review?
Attachment #419979 - Flags: review? → review?(mark.finkle)
Attachment #419979 - Flags: superreview?
i probably need to add a "this.setPluginState(true);"  Its 2010 and plugins.enabled still doesn't do a damn thing.
we can get rid of the preference by adding a "run once" callback here:

http://mxr.mozilla.org/mobile-browser/source/chrome/content/browser.js#545

put "Util.needHomepageOverride()" into a local, and test for "new profile".
Attached patch patch v.2 (obsolete) — Splinter Review
Attachment #419979 - Attachment is obsolete: true
Attachment #420121 - Flags: review?(mark.finkle)
Attachment #419979 - Flags: review?(mark.finkle)
Attachment #420121 - Flags: review?(mark.finkle) → review-
Comment on attachment 420121 [details] [diff] [review]
patch v.2

Moving the tile cache stuff won't work. The BrowserView is created at the top of Browser.startup and the constructor calls BrowserView.init, which sets the cache size.

Your code is setting the tile.cache.size preference at the bottom of Browser.startup - which is too late.
i'd like to keep these prefs-reset-based-on-device-type in the same place.  should I move initNewProfile to the start of Browser.startup?
Attached patch patch v.3Splinter Review
Attachment #420121 - Attachment is obsolete: true
Comment on attachment 420156 [details] [diff] [review]
patch v.3


>     // Command line arguments/initial homepage
>     let whereURI = "about:blank";
>-    switch (Util.needHomepageOverride()) {
>+
>+    switch (needOverride) {

Remove the blank line
Attachment #420156 - Flags: review+
tracking-fennec: --- → 1.0+
http://hg.mozilla.org/mobile-browser/rev/3c75260a9b45
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
verified FIXED on builds:

Mozilla/5.0 (X11; Linux armv7l; en-US; rv:1.9.2) Gecko/20100105 Firefox/3.6
Fennec/1.0

and

Mozilla/5.0 (X11; Linux armv6l; en-US; rv:1.9.2) Gecko/20100105 Firefox/3.6
Fennec/1.0
Status: RESOLVED → VERIFIED
Flags: in-litmus?
Comment on attachment 420156 [details] [diff] [review]
patch v.3

>diff --git a/chrome/content/browser.js b/chrome/content/browser.js

>+  initNewProfile: function initNewProfile() {

>+#ifdef MOZ_PLATFORM_HILDON
>+    // The flash plugin on the n8xx doesn't support the image expose fast
>+    // drawing we are doing. Disable all plugins by default. Users can override
>+    // in prefs
>+    if (device == "Nokia N8xx") {
>+      gPrefService.setBoolPref("plugins.enabled", false);
>+      this.setPluginState(true);

This doesn't look right, setPluginState(true) enables all plugins...
yes. we need to flip the flag.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Attached patch fix.Splinter Review
when I was testing this, i only verified that the UI changed. :(

To verify, you must load youtube.com or similar site and ensure that you see no flash content.
http://hg.mozilla.org/mobile-browser/rev/ad500c60b355
Status: REOPENED → RESOLVED
Closed: 14 years ago14 years ago
Resolution: --- → FIXED
verified FIXED on build:
Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.2) Gecko/20100111 Firefox/3.6pre Fennec/1.1a1pre
Status: RESOLVED → VERIFIED
Component: Linux/Maemo → General
QA Contact: maemo-linux → general
Flags: in-litmus? → in-litmus-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: