538174 - n900: App Manager only picks up xulrunner as an update option going from 12/5 nightly to rc2

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aakash Desai [:aakashd]]

Steps to Reproduce:
1. Download 12/5 nightly 1.9.2 build
2. Go to http://ftp.mozilla.org/pub/mozilla.org/mobile/candidates/1.0rc2-candidates/repos/1.9.2_multi/
3. Download and Open the install
4. After adding the catalog in the app manager, go to "Update"

Actual Results:
Only the xulrunner package 1.9.2pre-20100106010507 shows up as an update option and I receive a message that "fennec is already installed".

Expected Results:
I would expect both builds to be available to update.

Comment 1

[Aki Sasaki [:aki] (he/him)]

Heh, I'm going to guess that 1.0(string) is considered "newer" than 1.0

Comment 2

[Wolfgang Rosenauer [:wolfiR]]

Guessing that apt is basically doing the same as RPM that's indeed the case.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

* Make MOZ_APP_VERSION become branding dependent (move into branding/configure.sh)
* Update package strings and maintainer
* Include a buildid (date string) in the nightly deb package version

depends on bug 469202

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 2

Same as previous patch but fixed the debhelper version

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 3 (for landing)

Bumped the version

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Talked this over with mark on IRC - really don't like that we made the version depend on branding here. I think we should revert to setting in confvars.sh and instead just have the version bumps happen manually on the relbranch. I'll put up a patch.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Attachment: followup for default

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Attachment: followup for relbranch

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Landed those:
https://hg.mozilla.org/mobile-browser/rev/a3a539a74507
https://hg.mozilla.org/mobile-browser/rev/f789f40c380f

Comment 10

[:Gavin Sharp [email: [e-mail]]]

think we can call this fixed...

Comment 11

[Aki Sasaki [:aki] (he/him)]

Ok, this broke my repo update automation... I basically source confvars.sh and figure out the fennec deb name from that, then figure out the xulrunner deb name by downloading fennec + extracting the files.

The renames with dates will complicate this.  They will also fill up the latest-nightly directories with fennecs and xulrunners since they won't overwrite each other.

I can figure out workarounds for the above, but:

- weren't we updating from 1.0b6pre -> 1.0b6pre ?
- if so, couldn't we update from 1.1a1pre -> 1.1a1pre without the date string?

Also, won't updating from fennec_1.1a1pre~20100106202533_armel.deb -> fennec_1.1a1 be an issue?

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #11)

> I can figure out workarounds for the above, but:
> 
> - weren't we updating from 1.0b6pre -> 1.0b6pre ?
> - if so, couldn't we update from 1.1a1pre -> 1.1a1pre without the date string?
> 
> Also, won't updating from fennec_1.1a1pre~20100106202533_armel.deb ->
> fennec_1.1a1 be an issue?

From what I learned yesterday:
fennec_1.1a1pre > fennec_1.1a1pre~20100106202533

and:

fennec_1.1.0 > fennec_1.1a1pre

However:

fennec_1.1a1pre > fennec_1.1a1

So I don't know how we plan to release alphas and betas

Comment 13

[Stuart Parmenter]

(In reply to comment #12)
> However:
> 
> fennec_1.1a1pre > fennec_1.1a1
> 
> So I don't know how we plan to release alphas and betas

We need our debian package version to not include 'pre', unless it is after the ~

Comment 14

[Stuart Parmenter]

but at the same time, we want pre in our actual firefox version...

Comment 15

[Mark Finkle (:mfinkle) (use needinfo?)]

1.1a1~pre~2009 ?

We could make the app version be 1.1a1~pre in Firefox and the "~2009" would be tacked on for the debian version.

Comment 16

[Mark Finkle (:mfinkle) (use needinfo?)]

1.1a1 > 1.1a1~pre~2009

Comment 17

[Aki Sasaki [:aki] (he/him)]

(In reply to comment #15)
> We could make the app version be 1.1a1~pre in Firefox

That would be cool.

> and the "~2009" would be
> tacked on for the debian version.

Is the ~2009 necessary? (It would be easier to guess than down to the second, but if it's not necessary let's drop it.)

Comment 18

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: followup for default with version tweak

This patch moves the deb package version creation into the installer/Makefile and strips the "pre" from nightly deb package versions.

Comment 19

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: followup for default with version tweak 2

Now with better "pre" stripping

Comment 20

[Stuart Parmenter]

Comment on attachment 420611 [details] [diff] [review]
followup for default with version tweak 2

lets land this on default, but not on relbranch

Comment 21

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 420611 [details] [diff] [review]
followup for default with version tweak 2

I added gavin's changes in already

Comment 22

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed to default:
https://hg.mozilla.org/mobile-browser/rev/ba7bf70f98aa

bug 538455 covers the repo push breakage