53836 - JS errors on page loading: reference to undefined property window._content.HTTPIndex

Status: RESOLVED DUPLICATE of bug 55798

(SeaMonkey :: General, defect, P3)

Description

[rubydoo123]

Loading web pages (e.g. http://news.bbc.co.uk), I see lots of these errors:

JavaScript strict warning:
chrome://navigator/content/navigator.js line 1970: reference to undefined proper
ty window._content.HTTPIndex

Comment 1

[Radha on family leave (not reading bugmail)]

I think ben can handle this better. I let you decide.

Comment 2

[don]

Yep.  More correctness fun for Ben.

Ben, do we really need to fix this stuff before RTM?

Comment 3

[Simon Fraser [no longer active]]

The culprit here is the checkForDirectoryListing() function, which nhotta added. 
CCing him.

Comment 4

[nhottanscp]

There is another bug filed for this. The bug 53470 which was resolved as a dup 
of 51211.

Comment 5

[Henrik Gemal]

This is really really annoying since it totally floods the console with errors!

Comment 6

[Simon Fraser [no longer active]]

Reassign to nhotta. nhotta: i looked at the other bugs, and none of them 
addressed the JS error specifically, so this should stay open for that.

I'm also worried about the amount of times we're calling a JS function that is 
only there to detect directory listings. Can't this be optimized?

Comment 7

[nhottanscp]

The amount of times this to be called to be fixed by bug 51211. I applied the 
patch of 51211 then I only saw one warning per page load.
And here is a patch for the warning.

Index: browser/resources/content/navigator.js
===================================================================
RCS file: /cvsroot/mozilla/xpfe/browser/resources/content/navigator.js,v
retrieving revision 1.233
diff -c -r1.233 navigator.js
*** navigator.js	2000/09/20 12:23:49	1.233
--- navigator.js	2000/09/27 20:39:04
***************
*** 1967,1973 ****
  }
  
  function checkForDirectoryListing() {
!     if ( window._content.HTTPIndex == "[xpconnect wrapped nsIHTTPIndex]"
           &&
           typeof window._content.HTTPIndex == "object"
           &&
--- 1967,1974 ----
  }
  
  function checkForDirectoryListing() {
!     if ( "HTTPIndex" in window._content && 
!          window._content.HTTPIndex == "[xpconnect wrapped nsIHTTPIndex]"
           &&
           typeof window._content.HTTPIndex == "object"
           &&

Comment 8

[Doron Rosenberg (IBM)]

adding "approval" keyword, bug has a potential patch.

Comment 9

[sairuh (rarely reading bugmail)]

*** Bug 55381 has been marked as a duplicate of this bug. ***

Comment 10

[Simon Fraser [no longer active]]

r=sfraser on the patch.

Comment 11

[nhottanscp]

*** Bug 55381 has been marked as a duplicate of this bug. ***

Comment 12

[Jaime Rodriguez, Jr.]

Ftang - Doesn't this need to be marked as [RTM Need Info]?

Adding FTang to cc: list.

Comment 13

[Doron Rosenberg (IBM)]

nominating for mozilla0.9, if you think this should go into rtm, please nominate.

Comment 14

[Henrik Gemal]

*** This bug has been marked as a duplicate of 55798 ***