Closed Bug 538419 Opened 11 years ago Closed 10 years ago

remove nsAboutAbout.js

Categories

(SeaMonkey :: Build Config, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.1b1

People

(Reporter: steffen.wilberg, Assigned: Callek)

References

()

Details

Attachments

(1 file, 1 obsolete file)

In bug 220253, I readded the redirector to about:about to chrome://global/content/aboutAbout.xhtml, which is now part of Toolkit.

So you may want to remove your custom redirector in nsAboutAbout.js, and either drop your own aboutAbout.html, or replace the new Toolkit version with yours.
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20100108 SeaMonkey/2.1a1pre
still displays the old about:about page.

But my version looks much better: chrome://global/content/aboutAbout.xhtml
OS: Windows 7 → All
Hardware: x86 → All
Version: unspecified → Trunk
Flags: wanted-seamonkey2.1?
Don't see how this can be wanted-seamonkey2.1 when we don't know whether we'll be using 1.9.3 yet.
Flags: wanted-seamonkey2.1? → wanted-seamonkey2.1-
Assignee: nobody → bugspam.Callek
Attached patch Remove aboutAbout from suite/ (obsolete) — Splinter Review
...and inherently use toolkit's version
Attachment #464279 - Flags: review?(neil)
Doesn't it need to be a removed file?

Should we port the CSS changes too?
Oh, and we need to hide about:certerror too. See bug 538421.
(In reply to comment #4)
> Doesn't it need to be a removed file?

Yes.

> Should we port the CSS changes too?

Which CSS Change specifically?

(In reply to comment #5)
> Oh, and we need to hide about:certerror too. See bug 538421.

Hiding more pages from this that *we* expose should be done, yes. But can we do it in a followup?
(In reply to comment #6)
> (In reply to comment #4)
> > Should we port the CSS changes too?
> Which CSS Change specifically?
Actually I only remember one.

> (In reply to comment #5)
> > Oh, and we need to hide about:certerror too. See bug 538421.
> Hiding more pages from this that *we* expose should be done, yes. But can we do
> it in a followup?
Just saying, it would look odd that neterror is hidden but certerror is not.
The CSS change from bug 220253 was the two-column-style:
.columns {
  -moz-column-width: 20em;
  -moz-column-gap: 3em;
}

Did you consider unforking aboutAbout.xhtml and use the toolkit version?
That also takes care of hiding some about pages which are not useful without query parameters using nsIAboutModule.HIDE_FROM_ABOUTABOUT (bug 538421):
chrome://global/content/aboutAbout.xhtml
(In reply to comment #8)
> The CSS change from bug 220253 was the two-column-style:
> .columns {
>   -moz-column-width: 20em;
>   -moz-column-gap: 3em;
> }
Thanks.

> Did you consider unforking aboutAbout.xhtml and use the toolkit version?
This is effectively what this patch does!

> That also takes care of hiding some about pages which are not useful without
> query parameters using nsIAboutModule.HIDE_FROM_ABOUTABOUT (bug 538421):
See comment #5: some of our about pages don't have that flag when they should.
Ah, I was confused by aboutAbout.html not being removed as well, but of course without aboutAbout.js, the toolkit version is called instead.

Yeah, you'd have to add the HIDE_FROM_ABOUTABOUT flag to
/suite/common/src/nsAboutCertError.js
and maybe /suite/feeds/src/nsAboutFeeds.js.

(Search for ALLOW_SCRIPT in /suite/:
http://mxr.mozilla.org/comm-central/search?string=ALLOW_SCRIPT&case=1&find=%2Fsuite%2F )
(In reply to comment #10)
> Ah, I was confused by aboutAbout.html not being removed as well
Good catch!
Attachment #464279 - Flags: review?(neil) → review-
This should address all review comments.
Attachment #464279 - Attachment is obsolete: true
Attachment #468913 - Flags: review?(neil)
Comment on attachment 468913 [details] [diff] [review]
address review comments.

>-  lockFactory: function lockFactory(lock) {
>-    /* no-op */
>-  }
It's about time we got rid of this ;-)
Attachment #468913 - Flags: review?(neil) → review+
http://hg.mozilla.org/comm-central/rev/314ccc712341
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b1
You need to log in before you can comment on or make changes to this bug.