The default bug view has changed. See this FAQ.

remove nsAboutAbout.js

RESOLVED FIXED in seamonkey2.1b1

Status

SeaMonkey
Build Config
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Steffen Wilberg, Assigned: Callek)

Tracking

Trunk
seamonkey2.1b1
Dependency tree / graph
Bug Flags:
wanted-seamonkey2.1 -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

7 years ago
In bug 220253, I readded the redirector to about:about to chrome://global/content/aboutAbout.xhtml, which is now part of Toolkit.

So you may want to remove your custom redirector in nsAboutAbout.js, and either drop your own aboutAbout.html, or replace the new Toolkit version with yours.
(Reporter)

Comment 1

7 years ago
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20100108 SeaMonkey/2.1a1pre
still displays the old about:about page.

But my version looks much better: chrome://global/content/aboutAbout.xhtml
OS: Windows 7 → All
Hardware: x86 → All
Version: unspecified → Trunk
Flags: wanted-seamonkey2.1?

Comment 2

7 years ago
Don't see how this can be wanted-seamonkey2.1 when we don't know whether we'll be using 1.9.3 yet.
Flags: wanted-seamonkey2.1? → wanted-seamonkey2.1-
(Assignee)

Updated

7 years ago
Assignee: nobody → bugspam.Callek
(Assignee)

Comment 3

7 years ago
Created attachment 464279 [details] [diff] [review]
Remove aboutAbout from suite/

...and inherently use toolkit's version
Attachment #464279 - Flags: review?(neil)

Comment 4

7 years ago
Doesn't it need to be a removed file?

Should we port the CSS changes too?

Comment 5

7 years ago
Oh, and we need to hide about:certerror too. See bug 538421.
(Assignee)

Comment 6

7 years ago
(In reply to comment #4)
> Doesn't it need to be a removed file?

Yes.

> Should we port the CSS changes too?

Which CSS Change specifically?

(In reply to comment #5)
> Oh, and we need to hide about:certerror too. See bug 538421.

Hiding more pages from this that *we* expose should be done, yes. But can we do it in a followup?

Comment 7

7 years ago
(In reply to comment #6)
> (In reply to comment #4)
> > Should we port the CSS changes too?
> Which CSS Change specifically?
Actually I only remember one.

> (In reply to comment #5)
> > Oh, and we need to hide about:certerror too. See bug 538421.
> Hiding more pages from this that *we* expose should be done, yes. But can we do
> it in a followup?
Just saying, it would look odd that neterror is hidden but certerror is not.
(Reporter)

Comment 8

7 years ago
The CSS change from bug 220253 was the two-column-style:
.columns {
  -moz-column-width: 20em;
  -moz-column-gap: 3em;
}

Did you consider unforking aboutAbout.xhtml and use the toolkit version?
That also takes care of hiding some about pages which are not useful without query parameters using nsIAboutModule.HIDE_FROM_ABOUTABOUT (bug 538421):
chrome://global/content/aboutAbout.xhtml

Comment 9

7 years ago
(In reply to comment #8)
> The CSS change from bug 220253 was the two-column-style:
> .columns {
>   -moz-column-width: 20em;
>   -moz-column-gap: 3em;
> }
Thanks.

> Did you consider unforking aboutAbout.xhtml and use the toolkit version?
This is effectively what this patch does!

> That also takes care of hiding some about pages which are not useful without
> query parameters using nsIAboutModule.HIDE_FROM_ABOUTABOUT (bug 538421):
See comment #5: some of our about pages don't have that flag when they should.
(Reporter)

Comment 10

7 years ago
Ah, I was confused by aboutAbout.html not being removed as well, but of course without aboutAbout.js, the toolkit version is called instead.

Yeah, you'd have to add the HIDE_FROM_ABOUTABOUT flag to
/suite/common/src/nsAboutCertError.js
and maybe /suite/feeds/src/nsAboutFeeds.js.

(Search for ALLOW_SCRIPT in /suite/:
http://mxr.mozilla.org/comm-central/search?string=ALLOW_SCRIPT&case=1&find=%2Fsuite%2F )
(In reply to comment #10)
> Ah, I was confused by aboutAbout.html not being removed as well
Good catch!

Updated

7 years ago
Attachment #464279 - Flags: review?(neil) → review-
(Assignee)

Comment 12

7 years ago
Created attachment 468913 [details] [diff] [review]
address review comments.

This should address all review comments.
Attachment #464279 - Attachment is obsolete: true
Attachment #468913 - Flags: review?(neil)
Comment on attachment 468913 [details] [diff] [review]
address review comments.

>-  lockFactory: function lockFactory(lock) {
>-    /* no-op */
>-  }
It's about time we got rid of this ;-)
Attachment #468913 - Flags: review?(neil) → review+
(Assignee)

Comment 14

7 years ago
http://hg.mozilla.org/comm-central/rev/314ccc712341
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b1
You need to log in before you can comment on or make changes to this bug.