538855 - Mozmill: implement cleanup routine between test files to contain test failures to the same file

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect)

Comment 1

[Rain [:rain1] (inactive)]

Attachment: patch, v1

I've tested this patch out a bit and it seems to work fine. This should hopefully catch everything but premature shutdowns. asuth, how does this work for you?

We're playing around a bit with mozmill internals, but I'm not too concerned about any of this changing in the near future.

Comment 2

[Rain [:rain1] (inactive)]

Attachment: patch, v1.01

whoops.

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 421011 [details] [diff] [review]
patch, v1.01

So, even my 1.9.1 tree is not super happy even without this, but I assert that helps this patch show its worth much better.  Without the patch, some standalone message windows stack up.  With the patch, they get gone.  (And it does not break things that otherwise were reliable.)  Hooray!

Comment 4

[Rain [:rain1] (inactive)]

http://hg.mozilla.org/comm-central/rev/c539ad59cb6c

Comment 5

[Rain [:rain1] (inactive)]

Comment on attachment 421011 [details] [diff] [review]
patch, v1.01

This would be good to land so that we get a better idea of which tests are failing.

Comment 6

[Rain [:rain1] (inactive)]

http://hg.mozilla.org/releases/comm-1.9.1/rev/64b9b9a32293

Comment 7

[Mark Banner (:standard8)]

Verifying as fixed for 3.0.2 based on the fact that these are test-only patches and the last 5 runs from MozMill/unit tests have been green with no failures relating to these patches.