538888 - Add support for adding bookmark folders in BYOB

Status: VERIFIED FIXED

(Websites Graveyard :: byob.mozilla.com, defect, P1)

Description

[Kev Needham [:kev]]

In addition to individual bookmark links in BYOB, we'd like to be able to define and include bookmark folders in both the Bookmark Menu and Bookmark Toolbar. Bookmark folders would contain a maximum of ten entries, and would be added as a single item to the bookmark menu and/or toolbar within the configuration wizard.

Bookmark folders would be defined in the distribution.ini per that file's syntax (http://www.catsa-acsta.gc.ca/file/library/71/english/Exempt%20Items%20-%2008jan10(2)%20-%20EN.pdf), and would be subject to the limitations imposed on the maximum number of entries for the bookmark menu and toolbar. Nested folders would not be permitted. Localization of folder entries (and parent entries) should be available per bug 538615.

Folders would have the following requirements:

- be added as an entry type to the Bookmark section of the configuration wizard, separate from the bookmark menu and toolbar sections
- would require a folder name, and a minimum of one (1) entry per folder
- would provide UI to add/remove/modify Bookmark entries in the folder, up to a maximum of ten (10) entries
- if a bookmark folder is defined, that folder would be listed as an entry option in both the bookmark menu and toolbar entries for that build
- entries in folders should be listed in customization summaries/emails for simplified review by admins/editors

Comment 1

[Les Orchard [:lorchard]]

Added time estimate to whiteboard.  Also, I think you pasted the wrong PDF link there :)  (ie. ITEMS NOT COUNTED AS CARRY-ONS)

This also seems like a fairly UI-heavy change, so we might want to put some time into considering how that might work.  That may tweak the time estimate one way or another.

Comment 2

[Kev Needham [:kev]]

hah. I think you are correct with that link being incorrect. correct link is https://wiki.mozilla.org/Distribution_INI_File

Concur we should think about how we implement. Might be an idea to create the concept of defining a list of bookmarks and/or livemarks the author wants, and then adding a "folder(s)" section where a finite number of single level folders can be defined with the links from the list, and then having a section for the toolbar and menu where you just pick and choose from the defined [book,live]marks and folders.

Wow, that sounds cumbersome when I type it. Let's discuss.

Neilio: please flag this one for thoughts.

Comment 3

[Neil Lee [:neilio]]

Tackling the design component - some thoughts for ux requirements:

* mechanism to add/remove folders
* drag/drop to reorder bookmarks, move bookmarks between folders, reorder folders
* folder icons (pull from Fx, I assume)

More as I think of it, but I think this is the main UI changes required for this feature.

Comment 4

[Les Orchard [:lorchard]]

Bumping to P1, since I noticed this is mentioned in the Q1 goals

Comment 5

[Neil Lee [:neilio]]

So, I've got two separate concepts going - one follows the existing design of the Firefox bookmark manager fairly closely (folders in the left sidebar, bookmarks in the right area). Everything is drag and drop. Adding new bookmarks or folders pops open a small modal with the required fields.

The other uses a vertical stacked layout, with folders arranged with bookmarks indented underneath. I think this would be easier to implement, but it might be a bit cumbersome if we want to have nested folders (do we?).

I think the first option is preferred as it matches how Firefox users interact with bookmarks, but I can go either way.

I've got the mockups mostly finished for the sidebar layout, but it can be easily tweaked to vertical if that's what we decide.

Comment 6

[Neil Lee [:neilio]]

Attachment: Bookmark icons

Here's an archive of the various bookmark icons. Will add a delete icon once I either find one used in Firefox, or create one.

Comment 7

[Neil Lee [:neilio]]

Attachment: Mock of new bookmark manager

Comment 8

[Les Orchard [:lorchard]]

Okay, after several iterations, I think I'm most of the way there.

Still needs lots of visual polish, and the error case where a folder is submitted empty is a bit rough.

But, there should be some attempts at validation to make sure required fields are filled and URLs validate.  There's also an attempt to highlight relevant note bullet points when the user tries something that would violate the constraints - eg. dragging an item into a full folder, etc.  There seem to be a few cases where this doesn't work yet, so I'm still poking at that.

Also, the action buttons at the bottom should grey themselves out when the respective action is not appropriate.

Comment 9

[Les Orchard [:lorchard]]

Going to call this provisionally closed - go ahead and file bugs for any issues found or needful enhancements.

Comment 10

[Carsten Book [:Tomcat]]

verified