The default bug view has changed. See this FAQ.

Overflow at CEnumFormatEtc::Next

RESOLVED FIXED

Status

()

Core
Widget: Win32
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: khuey, Assigned: khuey)

Tracking

({regression, verified1.9.2})

unspecified
x86
Windows 7
regression, verified1.9.2
Points:
---
Bug Flags:
blocking1.9.0.19 -
wanted1.9.0.x +

Firefox Tracking Flags

(blocking1.9.2 .2+, status1.9.2 .2-fixed, blocking1.9.1 .9+, status1.9.1 .9-fixed)

Details

Attachments

(1 attachment)

Created attachment 420975 [details] [diff] [review]
Patch

https://bugzilla.mozilla.org/show_bug.cgi?id=537414#c7
Attachment #420975 - Flags: review?(jmathies)

Comment 1

7 years ago
Comment on attachment 420975 [details] [diff] [review]
Patch

+ PRUint32 count = NS_MIN(static_cast<PRUint32>(aMaxToFetch), left);

Do we need that static cast anymore?
Attachment #420975 - Flags: review?(jmathies) → review+

Comment 2

7 years ago
http://hg.mozilla.org/mozilla-central/rev/f5fca857c581
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Comment on attachment 420975 [details] [diff] [review]
Patch

We haven't seen any actual regressions from this yet (it's more of a theoretical bug than anything) but it's an easy fix so we may want to consider taking it on branch.
Attachment #420975 - Flags: approval1.9.2.1?
blocking1.9.1: --- → ?
status1.9.1: --- → wanted
Flags: wanted1.9.0.x+
Flags: blocking1.9.0.19?
nominated for older branches because it fixes a regression from bug 533691
blocking1.9.1: ? → needed
Flags: blocking1.9.0.19? → blocking1.9.0.19-
Keywords: regression
blocking1.9.1: needed → .9+
blocking1.9.2: --- → .2+
status1.9.2: --- → wanted
Comment on attachment 420975 [details] [diff] [review]
Patch

a1922=beltzner
Attachment #420975 - Flags: approval1.9.2.2? → approval1.9.2.2+
Landed on 1.9.2 as http://hg.mozilla.org/releases/mozilla-1.9.2/rev/263ee4ee7da2

Landed on 1.9.1 in the rollup.
status1.9.1: wanted → .9-fixed
status1.9.2: wanted → .2-fixed
I don't know what to test here. verified per check-in and verification of 533691
Keywords: verified1.9.2

Comment 8

7 years ago
(In reply to comment #7)
> I don't know what to test here. verified per check-in and verification of
> 533691

Nothing really to test, this was just a bug fix patch for some code that landed.
You need to log in before you can comment on or make changes to this bug.