539063 - Implement a whitelist and blacklist for OOPP

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Benjamin Smedberg]

For OOPP, it's likely that we'll want to start out with a whitelist of plugins that we've tested work with OOPP. At some point we may want to flip it to a blacklist of plugins that are known not to work.

Josh, can you take this or find an owner? We probably want to do this with prefs, but I'm not sure whether we can reliably key off the plugin filename or some other marker.

Comment 1

[Josh Aas]

Attachment: fix v1.0

I've only tested this on Linux so far but it probably works fine on Windows.

You can specify per-library exceptions to whatever "dom.ipc.plugins.enabled" indicates by setting boolean prefs like "dom.ipc.plugins.enabled.libnpfoo.so".

Comment 2

[Benjamin Smedberg]

Attachment: fix rev. 2, use string munging and normalize to lowercase

Josh, when reviewing this I thought of one issue and cleaned it up so we didn't need to use the localfile:

* because windows isn't case-sensitive, I've normalized the plugin name to lowercase before checking the pref
* Use string function RFindCharInSet instead of localfile->GetNativeLeafName because it's quicker and cleaner

Comment 3

[Benjamin Smedberg]

http://hg.mozilla.org/mozilla-central/rev/ac98eb7edabc

Comment 4

[Gary [:streetwolf52]]

How exactly do I use this?  I have a plugin that doesn't play well with OOPP and I'd like to blacklist it.

Thanks

Comment 5

[Benjamin Smedberg]

Starting with tomorrow's nightly:
* find the file name of your plugin by looking in about:plugins
* go to about:config
* create a new boolean pref "dom.ipc.plugins.enabled.<filename>" with value "false"

BTW, what plugin are you blacklisting?

Comment 6

[Gary [:streetwolf52]]

Foxit Reader, the latest version.

Comment 7

[Gary [:streetwolf52]]

looks like Bug 542792

Comment 8

[Philip Chee]

Would it be possible to specify a leafname without the extension so for example
dom.ipc.plugins.enabled.npswf32

will allow NPSWF32.dll NPSWF32.so NPSWF32.dylib etc.

Comment 9

[(not currently active) Ted Mielczarek]

The Flash plugin is:
npswf32.dll on Windows
libflashplayer.so on Linux
"Flash Player.plugin" on OS X.

I don't see how that would help anything.

Comment 10

[Benjamin Smedberg]

http://hg.mozilla.org/projects/firefox-lorentz/rev/575df83e56c0

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Blanket approval for Lorentz merge to mozilla-1.9.2
a=beltzner for 1.9.2.4 - please make sure to mark status1.9.2:.4-fixed

Comment 12

[Benjamin Smedberg]

Merged into 1.9.2 at http://hg.mozilla.org/releases/mozilla-1.9.2/rev/84ba4d805430

Comment 13

[Mardeg]

While this still remains a whitelist, what mechanism is in place to add plugins to the whitelist by default in newer releases?
If no bug about that exists, should one be filed based on stats gained from http://www.mozilla.com/en-US/plugincheck/ showing a rank of the most installed plugins?