remove broken Opera profile migrator

RESOLVED FIXED in Firefox 11

Status

()

Firefox
Migration
RESOLVED FIXED
8 years ago
6 years ago

People

(Reporter: dietrich, Assigned: m_kato)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

8 years ago
From File/Import, the only option available is "cookies".

When importing on "first run", the wizard shows the homepage import option, but only shows a single choice: the Firefox default homepage. Then the next page says migration complete, and the summary shows only cookies as being imported.

Updated

7 years ago
Whiteboard: [3.6RC1]
By code inspection, the Opera profile migrator hard-codes Opera 6-specific file names. Chances are that Opera has renamed the files since then.
(Reporter)

Updated

6 years ago
OS: Linux → All
Hardware: x86 → All
Whiteboard: [3.6RC1]
(Assignee)

Comment 2

6 years ago
Created attachment 578176 [details] [diff] [review]
fix
(Assignee)

Updated

6 years ago
Attachment #578176 - Flags: review?(gavin.sharp)
Does this fix all of the issues on all platforms? I'm pretty tempted to just remove the Opera profile migrator, at least until we can rewrite it in JS and properly test it fully.
(Assignee)

Comment 4

6 years ago
(In reply to Gavin Sharp (use gavin@gavinsharp.com for email) from comment #3)
> Does this fix all of the issues on all platforms? I'm pretty tempted to just
> remove the Opera profile migrator, at least until we can rewrite it in JS
> and properly test it fully.

Yes.  Opera 11 uses same filename on all platform (Windows/MacOSX/Linux).  Current code seems to be for Opera 6 per comment #1.

Also, I agree that we remove opera migration until rewriting new JS based code.  (although we need ini parser for js components...)

Gavin, should I remove this migration?
Yeah, let's just kill it, and file a followup to re-implement if needed.
(Assignee)

Updated

6 years ago
Blocks: 707601
(Assignee)

Comment 6

6 years ago
Created attachment 578981 [details] [diff] [review]
fix

kill opera migrator.
Assignee: nobody → m_kato
Attachment #578176 - Attachment is obsolete: true
Attachment #578981 - Flags: review?(gavin.sharp)
Attachment #578176 - Flags: review?(gavin.sharp)
(In reply to Makoto Kato from comment #4)
> (although we need ini parser for js components...)

What's wrong with nsIINIParser?
Comment on attachment 578981 [details] [diff] [review]
fix

A couple of things you forgot to remove:
- NS_OPERAPROFILEMIGRATOR_CID #define in nsBrowserCompsCID.h, and a reference to it in nsModule.cpp
- importFromOpera strings in migration.dtd

r=me with those addressed, thanks!
Attachment #578981 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 9

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/39f25929ceea
Status: NEW → ASSIGNED
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/39f25929ceea
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 11
Summary: Various parts of migration from Opera are broken → remove broken Opera profile migrator
You need to log in before you can comment on or make changes to this bug.