Closed Bug 539710 Opened 10 years ago Closed 6 years ago

Unsafe usage of PRUnichar with NS_LITERAL macro in nsNSSCertificate.cpp

Categories

(Core :: Security: PSM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: mak, Assigned: Cykesiopka)

Details

(Whiteboard: [psm-easy])

Attachments

(1 file, 1 obsolete file)

Assignee: kaie → nobody
Whiteboard: [psm-easy]
Attached patch bug539710_v1.patch (obsolete) — Splinter Review
Attachment #8344304 - Flags: review?(dkeeler)
Comment on attachment 8344304 [details] [diff] [review]
bug539710_v1.patch

Review of attachment 8344304 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good. However, going by bug 927728, let's use char16_t instead of PRUnichar. Also, I think the assignment will do the cast for you, so you don't need to explicitly include it.
Attachment #8344304 - Flags: review?(dkeeler) → review-
+ Switch to char16_t
Assignee: nobody → cykesiopka.bmo
Attachment #8344304 - Attachment is obsolete: true
Attachment #8344990 - Flags: review?(dkeeler)
Comment on attachment 8344990 [details] [diff] [review]
bug539710_v2.patch

Review of attachment 8344990 [details] [diff] [review]:
-----------------------------------------------------------------

Great - thanks.
Attachment #8344990 - Flags: review?(dkeeler) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4889070e0eea
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.