539710 - Unsafe usage of PRUnichar with NS_LITERAL macro in nsNSSCertificate.cpp

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Marco Bonardo [::mak] (Away 7-25 Aug)]

http://mxr.mozilla.org/mozilla-central/source/security/manager/ssl/src/nsNSSCertificate.cpp#293

const PRUnichar *comma = NS_LITERAL_STRING(",").get();

See https://bugzilla.mozilla.org/show_bug.cgi?id=461199#c143 and https://bugzilla.mozilla.org/show_bug.cgi?id=461199#c145 for reasoning.

Comment 1

[:Cykesiopka]

Attachment: bug539710_v1.patch

Comment 2

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Comment on attachment 8344304 [details] [diff] [review]
bug539710_v1.patch

Review of attachment 8344304 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good. However, going by bug 927728, let's use char16_t instead of PRUnichar. Also, I think the assignment will do the cast for you, so you don't need to explicitly include it.

Comment 3

[:Cykesiopka]

Attachment: bug539710_v2.patch

+ Switch to char16_t

Comment 4

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Comment on attachment 8344990 [details] [diff] [review]
bug539710_v2.patch

Review of attachment 8344990 [details] [diff] [review]:
-----------------------------------------------------------------

Great - thanks.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4889070e0eea

Comment 6

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/mozilla-central/rev/4889070e0eea