Closed
Bug 539710
Opened 13 years ago
Closed 9 years ago
Unsafe usage of PRUnichar with NS_LITERAL macro in nsNSSCertificate.cpp
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: mak, Assigned: Cykesiopka)
Details
(Whiteboard: [psm-easy])
Attachments
(1 file, 1 obsolete file)
963 bytes,
patch
|
keeler
:
review+
|
Details | Diff | Splinter Review |
http://mxr.mozilla.org/mozilla-central/source/security/manager/ssl/src/nsNSSCertificate.cpp#293 const PRUnichar *comma = NS_LITERAL_STRING(",").get(); See https://bugzilla.mozilla.org/show_bug.cgi?id=461199#c143 and https://bugzilla.mozilla.org/show_bug.cgi?id=461199#c145 for reasoning.
Updated•12 years ago
|
Assignee: kaie → nobody
Whiteboard: [psm-easy]
![]() |
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8344304 -
Flags: review?(dkeeler)
Comment on attachment 8344304 [details] [diff] [review] bug539710_v1.patch Review of attachment 8344304 [details] [diff] [review]: ----------------------------------------------------------------- This looks good. However, going by bug 927728, let's use char16_t instead of PRUnichar. Also, I think the assignment will do the cast for you, so you don't need to explicitly include it.
Attachment #8344304 -
Flags: review?(dkeeler) → review-
![]() |
Assignee | |
Comment 3•9 years ago
|
||
+ Switch to char16_t
Assignee: nobody → cykesiopka.bmo
Attachment #8344304 -
Attachment is obsolete: true
Attachment #8344990 -
Flags: review?(dkeeler)
Comment on attachment 8344990 [details] [diff] [review] bug539710_v2.patch Review of attachment 8344990 [details] [diff] [review]: ----------------------------------------------------------------- Great - thanks.
Attachment #8344990 -
Flags: review?(dkeeler) → review+
![]() |
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4889070e0eea
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4889070e0eea
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•