Closed Bug 927728 Opened 7 years ago Closed 7 years ago

Convert PRUnichar to char16_t across the code base

Categories

(Core :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: ehsan, Assigned: ehsan)

References

(Blocks 1 open bug)

Details

(Whiteboard: [qa-])

Attachments

(3 files)

I'll do this once bug 895047 sticks.
OS: Mac OS X → All
Hardware: x86 → All
This is an automatically generated patch based on the script that I used for bug 579517.  The most interesting bit to review is the actual script in the commit message.
Attachment #8355369 - Flags: review?(roc)
Comment on attachment 8355370 [details] [diff] [review]
Part 2: Stop using PRUnichar in our code generators

Review of attachment 8355370 [details] [diff] [review]:
-----------------------------------------------------------------

looks good to me but I am not the right reviewer here
Attachment #8355370 - Flags: review?(roc)
Attachment #8355370 - Flags: review?(bzbarsky)
Attachment #8355370 - Flags: review+
Comment on attachment 8355370 [details] [diff] [review]
Part 2: Stop using PRUnichar in our code generators

r=me for certain on the webidl bit.  I'll pretend like I can do that for the xpidl one too.  ;)

I assume that char16_t and PRUnichar are binary-compatible on all our supported platforms, right?
Attachment #8355370 - Flags: review?(bzbarsky) → review+
(In reply to comment #6)
> I assume that char16_t and PRUnichar are binary-compatible on all our supported
> platforms, right?

Yes.  In fact, as of bug 895047, PRUnichar has been a typedef to char16_t, so this patch just removes one level of typedef indirection.
https://hg.mozilla.org/mozilla-central/rev/5a9badd6db00
https://hg.mozilla.org/mozilla-central/rev/cf80c0d4f46e
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Blocks: 956507
Blocks: 956995
Depends on: 957356
Depends on: 958497
Ehsan

What would be required to get this uplifted? This issue that this patch fixes has broken the way that Selenium WebDriver does keyboard interactions
Flags: needinfo?(ehsan)
This patch only changes the types of some variables at compile time, and it should have caused no runtime behavior changes.  Why do you think that this has fixed something in selenium?
Flags: needinfo?(ehsan)
Whiteboard: [qa-]
Blocks: 1194497
You need to log in before you can comment on or make changes to this bug.