Convert PRUnichar to char16_t across the code base

RESOLVED FIXED in mozilla29

Status

()

defect
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

(Blocks 1 bug)

Trunk
mozilla29
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(3 attachments)

Assignee

Description

6 years ago
I'll do this once bug 895047 sticks.
OS: Mac OS X → All
Hardware: x86 → All
Assignee

Comment 1

6 years ago
This is an automatically generated patch based on the script that I used for bug 579517.  The most interesting bit to review is the actual script in the commit message.
Attachment #8355369 - Flags: review?(roc)
Assignee

Comment 3

6 years ago
Comment on attachment 8355370 [details] [diff] [review]
Part 2: Stop using PRUnichar in our code generators

Review of attachment 8355370 [details] [diff] [review]:
-----------------------------------------------------------------

looks good to me but I am not the right reviewer here
Attachment #8355370 - Flags: review?(roc)
Attachment #8355370 - Flags: review?(bzbarsky)
Attachment #8355370 - Flags: review+
Comment on attachment 8355370 [details] [diff] [review]
Part 2: Stop using PRUnichar in our code generators

r=me for certain on the webidl bit.  I'll pretend like I can do that for the xpidl one too.  ;)

I assume that char16_t and PRUnichar are binary-compatible on all our supported platforms, right?
Attachment #8355370 - Flags: review?(bzbarsky) → review+
Assignee

Comment 7

6 years ago
(In reply to comment #6)
> I assume that char16_t and PRUnichar are binary-compatible on all our supported
> platforms, right?

Yes.  In fact, as of bug 895047, PRUnichar has been a typedef to char16_t, so this patch just removes one level of typedef indirection.
Assignee

Comment 8

6 years ago
https://hg.mozilla.org/mozilla-central/rev/5a9badd6db00
https://hg.mozilla.org/mozilla-central/rev/cf80c0d4f46e
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Assignee

Updated

6 years ago
Blocks: 956507
Blocks: 956995
Assignee

Updated

6 years ago
Depends on: 957356
Assignee

Updated

6 years ago
Depends on: 958497
Ehsan

What would be required to get this uplifted? This issue that this patch fixes has broken the way that Selenium WebDriver does keyboard interactions
Flags: needinfo?(ehsan)
Assignee

Comment 10

5 years ago
This patch only changes the types of some variables at compile time, and it should have caused no runtime behavior changes.  Why do you think that this has fixed something in selenium?
Flags: needinfo?(ehsan)

Updated

5 years ago
Whiteboard: [qa-]
Blocks: 1194497
You need to log in before you can comment on or make changes to this bug.