927728 - Convert PRUnichar to char16_t across the code base

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[(no longer active)]

I'll do this once bug 895047 sticks.

Comment 1

[(no longer active)]

Attachment: Part 1: Replace PRUnichar with char16_t

This is an automatically generated patch based on the script that I used for bug 579517.  The most interesting bit to review is the actual script in the commit message.

Comment 2

[(no longer active)]

Attachment: Part 2: Stop using PRUnichar in our code generators

Comment 3

[(no longer active)]

Attachment: Script to unbitrot patches in mq

Comment 4

[(no longer active)]

https://tbpl.mozilla.org/?tree=Try&rev=ff3f71a5f5ec

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8355370 [details] [diff] [review]
Part 2: Stop using PRUnichar in our code generators

Review of attachment 8355370 [details] [diff] [review]:
-----------------------------------------------------------------

looks good to me but I am not the right reviewer here

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8355370 [details] [diff] [review]
Part 2: Stop using PRUnichar in our code generators

r=me for certain on the webidl bit.  I'll pretend like I can do that for the xpidl one too.  ;)

I assume that char16_t and PRUnichar are binary-compatible on all our supported platforms, right?

Comment 7

[(no longer active)]

(In reply to comment #6)
> I assume that char16_t and PRUnichar are binary-compatible on all our supported
> platforms, right?

Yes.  In fact, as of bug 895047, PRUnichar has been a typedef to char16_t, so this patch just removes one level of typedef indirection.

Comment 8

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/5a9badd6db00
https://hg.mozilla.org/mozilla-central/rev/cf80c0d4f46e

Comment 9

[David Burns :automatedtester]

Ehsan

What would be required to get this uplifted? This issue that this patch fixes has broken the way that Selenium WebDriver does keyboard interactions

Comment 10

[(no longer active)]

This patch only changes the types of some variables at compile time, and it should have caused no runtime behavior changes.  Why do you think that this has fixed something in selenium?