539780 - Move core CC* master code to buildbotcustom

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Robert Kaiser]

Just like bug 508312 has moved the Firefox etc. core master.cfg stuff into buildbotcustom's misc.py, I think it would be nice to do that for the comm-* projects, so that we can share even more code and so that someone improving the Firefox side can easily catch our side as well.

I have a SeaMonkey config with this up to a state where checkconfig succeeds, I'll try to get this fully running for SeaMonkey before I ask for review - but what I did is to start from the generateBranchObjects() used by Firefox and adapted it for us, stripping the XULRunner stuff but leaving the shark stuff in even though SeaMonkey doesn't use it, as I guess Thunderbird might want to use it.

Comment 1

[Robert Kaiser]

Attachment: WIP patch

This patch is just a WIP at the stage where I got checkconfig to accept everything - just to get a feel where it's heading and so gozer can see if it's feasible to head this way at all.

Comment 2

[Reed Loden [:reed]]

I think you have the wrong component here...

Comment 3

[Robert Kaiser]

(In reply to comment #2)
> I think you have the wrong component here...

oops, sure...

Comment 4

[Robert Kaiser]

http://hg.mozilla.org/build/buildbot-configs/rev/4d5b0dffae4b and http://hg.mozilla.org/build/buildbot-configs/rev/46f84465a4f0 are the config changes I needed along with that patch, and actually with that, the SeaMonkey master survived a reconfig - let's see how it holds up...

Comment 5

[Robert Kaiser]

Attachment: add the core of the master to misc.py

Here's the first tested patch, and one that is already deployed and working on the SeaMonkey buildmaster. Compared to the WIP, the differences are quite small: productName is being handed to the packaged test factory for bug 541225, a poller for mozilla_repo_path is being added again, and CCUnittestBuildFactory exec_* settings are handed over, including a new one to turn xpcshell on/off there (when we run packaged tests, we want nothing but "make check" to be run right with the builder itself, everything else is handed off to packaged tests).

For the latter change, http://hg.mozilla.org/build/buildbot-configs/rev/8b6324d4b226 is an example for the config changes.

Comment 6

[Robert Kaiser]

As a side note, I have an additional parameter in the UnittestPackagedBuildFactory calls locally and on the SeaMonkey master now, to make the bug 541582 patch work, but it's a trivial printMozillaRev=True and nothing breaks without it, so I won't attach a new patch for the moment.

Comment 7

[Robert Kaiser]

Thanks for review, pushed as http://hg.mozilla.org/build/buildbotcustom/rev/7ad8012e2926
\o/