541169 - UnittestPackagedBuildFactory hardcodes "firefox"

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Robert Kaiser]

UnittestPackagedBuildFactory currently hardcodes "firefox" as (parts of) the binary and path names, but if we want to be able to use it for different products, we need to be able to hand in different product names.

Comment 1

[Robert Kaiser]

Attachment: accept a productName parameter

This patch makes UnittestPackagedBuildFactory accept a productName parameter and default back to 'firefox' if it is not passed, so things should degrade easily.

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 422843 [details] [diff] [review]
accept a productName parameter

>diff --git a/process/factory.py b/process/factory.py

>         self.env = MozillaEnvironments['%s-unittest' % self.platform].copy()
>         self.env['MINIDUMP_STACKWALK'] = getPlatformMinidumpPath(self.platform)
>         self.env.update(env)
>+        self.productName = productName or 'firefox'

Just set the default the __init__ signature. This technique is only necessary for things like lists or dicts which have shared reference issues.

Looks fine otherwise.

Comment 3

[Robert Kaiser]

Attachment: accept a productName parameter, v1.1

Right, how could I forget to do things that way - I guess it's been too long since I did more serious buildbot stuff... ;-)

Here's the updated patch.

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 422970 [details] [diff] [review]
accept a productName parameter, v1.1

hchangeset:   587:4785b95b4155

Comment 5

[[e-mail] (:bhearsum)]

I think we can close this now.