Try and automatically generate/update thunderbirdDetails.class.php

RESOLVED FIXED

Status

Mozilla Messaging
Release Engineering
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
This is something we need to do at every security release. There's also thunderbirdBetaDetails.class.php that's done for alpha/beta releases.

I'd like to have a way whereby we can automatically generate/update the file post signing so that all we have to do is copy it to the website.

Note that this would ideally be an independent step so that we could trigger it manually in case thunderbirdDetails.class.php (e.g. an additional 2.0.0.x release) was updated between the build and the release time (although we could just fix diffs, but this would be a simpler in theory).
(Assignee)

Updated

8 years ago
Depends on: 540394
(Assignee)

Updated

8 years ago
Blocks: 540394
No longer depends on: 540394
(Assignee)

Comment 1

8 years ago
Note: it may be simpler to do if this isn't a buildbot step, but a standalone script (that could also be triggered by a buildbot step, of course).
(Assignee)

Updated

8 years ago
Assignee: gozer → bugzilla
(Assignee)

Updated

8 years ago
Depends on: 555040
(Assignee)

Comment 2

8 years ago
I've now finished what I'll call the first version of the script that I've also used to regenerate the Thunderbird product-details as seen in bug 555040.

The script can be found at: http://hg.mozilla.org/users/bugzilla_standard8.plus.com/drivertools/file/default/website/generateThunderbirdDetails.py
(Assignee)

Comment 3

8 years ago
Created attachment 436168 [details] [diff] [review]
generateThunderbirdDetails.py revision 70d7bdb17051

gozer, can you give this a quick once over? I know the output should be right, but it'd be good if you can just make sure I've not done anything drastically bad.
Attachment #436168 - Flags: review?(gozer)
(In reply to comment #3)
> Created an attachment (id=436168) [details]
> generateThunderbirdDetails.py revision 70d7bdb17051
> 
> gozer, can you give this a quick once over?

Looks good, the only issue I have is with the special casing of the ja-JP-mac locale, which seems incorrect to me.  It works right now, but it won't handle another locale that would be such an exception.

It does work, however, so probably good enough for v1
Attachment #436168 - Flags: review?(gozer) → review+
(Assignee)

Comment 5

8 years ago
(In reply to comment #4)
> (In reply to comment #3)
> > Created an attachment (id=436168) [details] [details]
> > generateThunderbirdDetails.py revision 70d7bdb17051
> > 
> > gozer, can you give this a quick once over?
> 
> Looks good, the only issue I have is with the special casing of the ja-JP-mac
> locale, which seems incorrect to me.  It works right now, but it won't handle
> another locale that would be such an exception.

Yeah, I think that's something to consider for when we get another awkward locale ;-)
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.