539943 - Set up builders for Lightning 1.0b2pre for Thunderbird 3.1

Status: RESOLVED FIXED

(Calendar :: Build Config, defect, P2)

Description

[Philipp Kewisch [:Fallen][☁️📆]]

Now that we have released 1.0b1, we need to make sure the builders are doing the right thing w.r.t 1.0b2pre.

1.0b2pre should be released near Thunderbird 3.1 (mozilla 1.9.2). This means we need to change the current 1.9.1 builders to use 1.9.2. We also need to make sure we are cloning the right 1.9.2: we need to have the one that has the same mozstorage changes that Thunderbird has. This may be a non-issue though, in case 1.9.2 contains those fixes.

I'm not sure what all needs to be changed, gozer told me its a mozconfig issue, but then again the tinderbox should also report "comm-1.9.2", and we need to make sure the build land at ftp://..../latest-comm-1.9.2.

Please correct me if I am wrong, I haven't quite understood how the branching for Tb 3.1 will work.

Comment 1

[Philipp Kewisch [:Fallen][☁️📆]]

We should take care of this bug before further checkins to better identify possible regressions. Raising importance.

Comment 2

[Stefan Sitter [:ssitter]]

Is this about Sunbird or Lightning or both? 

Do you really want to move the builders from 1.9.1 to 1.9.2? Or do you want to add new ones for 1.9.2? In the former case this means we would loose Lightning support for 1.9.1 based builds like Thunderbird 3.0?

Comment 3

[Philippe M. Chiasson (:gozer)]

Attachment: move lightning 1.9.1 buildbot slaves to 1.9.2

Comment 4

[Philippe M. Chiasson (:gozer)]

(In reply to comment #2)
> Is this about Sunbird or Lightning or both? 
> 
> Do you really want to move the builders from 1.9.1 to 1.9.2? Or do you want to
> add new ones for 1.9.2? In the former case this means we would loose Lightning
> support for 1.9.1 based builds like Thunderbird 3.0?

One problem with doing both 1.9.1 and 1.9.2 builds will be disk space, as the Linux and Windows build boxes are already pretty short on spare space.

Comment 5

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 422230 [details] [diff] [review]
move lightning 1.9.1 buildbot slaves to 1.9.2 

>+BRANCHES['comm-1.9.2-lightning']['mozilla_central_branch'] = 'releases/mozilla-1.9.2'
>+BRANCHES['comm-1.9.2-lightning']['branch_name'] = 'comm-1.9.2'
>+BRANCHES['comm-1.9.2-lightning']['hg_branch'] = 'releases/comm-1.9.1'
I'd appreciate some explaination on how the branching for Thunderbird 3.1 is going to work. Presumably we should do this the same. The above suggests that we need to pull releases/comm-1.9.1, but why 1.9.1?

If we pull from comm-1.9.1, this means we need to cross-commit all future checkins, which was annoying enough during release times. What other options do we have?

Given we are not supporting Sunbird after 1.0b1, I don't really care what branch Sunbird stays on. Maybe we should stay on 1.9.1 for Sunbird since its the last working branch.

Stefan, what do you think?

Comment 6

[Philippe M. Chiasson (:gozer)]

(In reply to comment #5)
> (From update of attachment 422230 [details] [diff] [review])
> >+BRANCHES['comm-1.9.2-lightning']['mozilla_central_branch'] = 'releases/mozilla-1.9.2'
> >+BRANCHES['comm-1.9.2-lightning']['branch_name'] = 'comm-1.9.2'
> >+BRANCHES['comm-1.9.2-lightning']['hg_branch'] = 'releases/comm-1.9.1'
> I'd appreciate some explaination on how the branching for Thunderbird 3.1 is
> going to work. Presumably we should do this the same. The above suggests that
> we need to pull releases/comm-1.9.1, but why 1.9.1?

That was a mistake on my part, it should have been comm-central.

> If we pull from comm-1.9.1, this means we need to cross-commit all future
> checkins, which was annoying enough during release times. What other options do
> we have?
> 
> Given we are not supporting Sunbird after 1.0b1, I don't really care what
> branch Sunbird stays on. Maybe we should stay on 1.9.1 for Sunbird since its
> the last working branch.

Sunbird is configured completely separately from Lightning, so it's not a problem at all to leave it on 1.9.1

Comment 7

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 422230 [details] [diff] [review]
move lightning 1.9.1 buildbot slaves to 1.9.2 


>+BRANCHES['comm-1.9.2-lightning']['hg_branch'] = 'releases/comm-1.9.1'
Change to comm-central as discussed, otherwise r=philipp

Comment 8

[Stefan Sitter [:ssitter]]

Comment on attachment 422230 [details] [diff] [review]
move lightning 1.9.1 buildbot slaves to 1.9.2 

>+++ b/thunderbird/config.py
>@@ -74,7 +74,8 @@
>-    'comm-1.9.1-lightning': {},
>+    'comm-1.9.2-lightning': {},
>+    'comm-1.9.2-lightning': {},

I guess 'comm-1.9.2-lightning' is only required once?

Comment 9

[Philipp Kewisch [:Fallen][☁️📆]]

Stefan's and my comment taken into account and

Pushed to buildbot-configs <http://hg.mozilla.org/build/buildbot-configs/rev/af80143e25cf>

-> FIXED

Comment 10

[Stefan Sitter [:ssitter]]

Doesn't seem to work. Lightning still builds 1.9.1, no sign of 1.9.2 builds on <http://tinderbox.mozilla.org/showbuilds.cgi?tree=Calendar1.0> or <http://ftp.mozilla.org/pub/mozilla.org/calendar/lightning/tinderbox-builds/>.

Comment 11

[David Flory]

The builds at /pub/mozilla.org/calendar/lightning/nightly/latest-comm-central/win32-xpi are not working for me with the Lanikai/3.1b1pre nightlies.

Comment 12

[Mark Banner (:standard8)]

Unless there's a missing change in the configs, which I doubt, I very much suspect gozer hasn't reconfigured the buildbot master yet, if he has, then something doesn't look right as it is still listing lightning as building on 1.9.1.

Comment 13

[Philipp Kewisch [:Fallen][☁️📆]]

Yes, thats probably it. I checked in this patch in hopes that everything would go automatically since I haven't heard from gozer for a while.

Comment 14

[Philipp Kewisch [:Fallen][☁️📆]]

David, the latest-comm-central directory is for 3.2a1pre builds. When the changes from this patch actually show effect, there should be a latest-comm-1.9.2 directory.

Comment 15

[Stefan Sitter [:ssitter]]

Lightning builds for Windows and Linux are now available. 
The builds for Mac OS X are failing with a postflight error.

Comment 18

[Mark Banner (:standard8)]

(In reply to comment #15)
> Lightning builds for Windows and Linux are now available. 
> The builds for Mac OS X are failing with a postflight error.

Gozer:

Can you add:

http://hg.mozilla.org/build/buildbot-configs/file/a54f1d2d5d7e/thunderbird/config.py#l609 (i.e. DISABLE_LIGHTNING_INSTALL=1)

onto the Lightning 1.9.2 Mac builds please.

Comment 19

[Philippe M. Chiasson (:gozer)]

(In reply to comment #18)
> (In reply to comment #15)
> [...]
> 
> Gozer:
> Can you add:
> http://hg.mozilla.org/build/buildbot-configs/file/a54f1d2d5d7e/thunderbird/config.py#l609
> (i.e. DISABLE_LIGHTNING_INSTALL=1)
> 
> onto the Lightning 1.9.2 Mac builds please.

Done.

Comment 20

[Philipp Kewisch [:Fallen][☁️📆]]

All builds are green and building, closing this bug. Thanks for taking care!