539973 - Add-on installation fails it has an EULA and the "Experimental" checkbox needs to be clicked

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P3)

Description

[Jorge Villalobos [:jorgev] (he/him)]

For the add-on author:

> We have posted our addon: Write My Language:
> https://addons.mozilla.org/en-US/firefox/addon/54456
> Unfortunately there is a problem with installing it. If you go from the
> previous link and click on "Let me install this experimental add-on" and hit 
> "Add to Firefox" it will take you to the License information page 
> (https://addons.mozilla.org/en-US/firefox/addons/policy/0/54456/75791?src=addondetail&confirmed) 
> where you have to say "Accept and Install". Once done that you get the error
>  message:
> Firefox could not install the file at
> https://addons.mozilla.org/en-US/firefox/downloads/file/75791/write_my_language-1.1.1-fx.xpi?src=addondetail?confirmed
> because: Invalid file hash (possible download corruption)
> -261
> But if you change your URL into 
> (https://addons.mozilla.org/en-US/firefox/addons/policy/0/54456/75791?src=addondetail)
> by removing the last (&confirmed) word from its ending, then installation
> works.

I can confirm that the installation works when logged in, but not when logeed out. I think this is a combination of having to click the Experimental checkbox and having to go through an additional step (EULA).

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

Reopening this bug given that it is much more specific (better info).

Comment 8

[Jorge Villalobos [:jorgev] (he/him)]

-> major

Lots of occurrences now.

Comment 9

[Wil Clouser [:clouserw]]

Attachment: fix

Why wouldn't we have done this to begin with?

Comment 10

[Fred Wenzel [:wenzel]]

Comment on attachment 423048 [details] [diff] [review]
fix

wow.

Comment 11

[Wil Clouser [:clouserw]]

r61041.  Seems like I would have done that for a reason but I don't remember.  Tests--

Comment 12

[Strainu]

Has this code gotten into the site yet? I can still see the behavior in Bug 540384 for my extension: https://addons.mozilla.org/ro/firefox/addon/14296

Comment 13

[Fred Wenzel [:wenzel]]

(In reply to comment #12)
> Has this code gotten into the site yet?

No, it's planned to be released on February 2. (https://wiki.mozilla.org/AMO:Meeting_Notes)

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

FWIW, I can't install from preview: https://preview.addons.mozilla.org/en-US/firefox/addons/policy/0/54456/74695?src=addondetail&confirmed, because of a -207 error; do we just need a fresh dump?  (In the meantime, I'll look for other experimental add-ons that work; I got a -207 error (which duped bug 540384 is all about) when trying to install my own Stephen3000!!! add-on (8585 on preview), so I can't yet verify this fix.

Comment 15

[Strainu]

Mine works OK (no -207 error) from https://preview.addons.mozilla.org/en-US/firefox/addons/policy/0/14296/64402?src=addondetail&confirmed

Comment 16

[technoLinguistics]

I'm still getting: because: Not a valid install package -207
https://addons.mozilla.org/en-US/firefox/addons/policy/0/54456/76350?src=search&confirmed
Is the solution not committed yet?

Comment 17

[Dave Garrett]

(In reply to comment #16)
> I'm still getting: because: Not a valid install package -207
> https://addons.mozilla.org/en-US/firefox/addons/policy/0/54456/76350?src=search&confirmed
> Is the solution not committed yet?

Committed fixes take effect automatically on the preview server, but not the production server. AMO bugs with the "push-needed" keyword are fixed on preview but not yet on production. After testing, groups of fixes are pushed together for each new AMO update. You can test using preview.addons.mozilla.org instead. (i.e. comment 14 & comment 15)

Comment 18

[gg0687644]

I am still getting the same 207 error on preview site.
https://preview.addons.mozilla.org/en-US/firefox/addon/10917

Comment 19

[Jan Wedding]

I am getting an -207 error for *all* Add-Ons on the preview site...

Comment 20

[Dave Garrett]

(In reply to comment #19)
> I am getting an -207 error for *all* Add-Ons on the preview site...

If you didn't upload the file to preview then it's not going to work. Preview usually has its files out of sync with its database and pages.

Comment 21

[Axel Nennker]

The policy to mark an AMO bug as "resolved fixed" when the users still have to experience the effects of the bug is strange.
When is the next update to AMO?

Comment 22

[Fred Wenzel [:wenzel]]

(In reply to comment #21)
> When is the next update to AMO?

See comment 13.

Comment 23

[Dave Garrett]

(In reply to comment #21)
> The policy to mark an AMO bug as "resolved fixed" when the users still have to
> experience the effects of the bug is strange.

It's the same policy as almost everything else in Bugzilla. Firefox bugs get marked as fixed when the bug's fix is committed, which is usually long before an update that includes recent fixes. Suggestions exist to improve status labeling, but for now fixed is equivalent to "fix committed".

Comment 24

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #15)
> Mine works OK (no -207 error) from
> https://preview.addons.mozilla.org/en-US/firefox/addons/policy/0/14296/64402?src=addondetail&confirmed

I now get a -203 error.

Comment 25

[Stephen Donner [:stephend] Not actively reading bugmail]

This probably would benefit from bug 542644 being fixed; setting a dependency.

Comment 26

[krupa raj[:krupa]]

works fine on search tools.

Comment 27

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; also works on the preview URLs mentioned here.

Comment 28

[Jorge Villalobos [:jorgev] (he/him)]

This is still happening. It was reported today by the author of this add-on: https://addons.mozilla.org/en-US/firefox/addon/53880/

I can confirm the same behavior occurs. This URL throws an error if you're not logged in:
https://addons.mozilla.org/en-US/firefox/downloads/file/83564/memory_fox-1.4.5-fx-win.xpi?src=addondetail&confirmed
And removing the 'confirmed' parameter fixes the issue.

Comment 29

[Jeff Balogh (:jbalogh)]

Shall we give this to the zamboni?

Comment 30

[Strainu]

Jeff, would you be considerate enough with us non-native speakers to translate the last comment? I have no idea what "give it to the zamboni" means. Most google results are about different sexual positions, but I'm pretty sure it's not what you had in mind :)

Comment 31

[Jorge Villalobos [:jorgev] (he/him)]

Zamboni is a codeword for the upcoming AMO platform shift: http://blog.fligtar.com/2010/01/15/amo-zamboni-planning-underway/

If I read Jeff's comment correctly, it would mean something like "let's not fix this right away".

Comment 32

[IDEVFH]

Hi AMO,

Since the last bugzilla report seems to suggest the Mozilla developers will wait to fix the problem, I've removed "Memory Fox's" End-User License Agreement.

After removal of the "Memory Fox" version 1.4.6 EULA, I'm still getting emails due to -261 download problems.

https://addons.mozilla.org/en-US/firefox/addon/53880

I mentioned in my Developer's Comment on the current release the following:

Failure To Download And Install:
Log into Mozilla Firefox and go back to the addon of "Memory Fox" and retry download. It may take a 2 or 3 times. This is a known issue due to Mozilla's download of addons, sorry !

Some users say they are successful download following the instruction while others stay fustrated.

What should I do ?

Regards,
IDEVFH

Comment 33

[IDEVFH]

Hi AMO,

Still same issue ERROR -261 reported by "Memory Fox" download users.
https://addons.mozilla.org/en-US/firefox/addon/53880/

I also noticed that uploading sometimes creates 2 - 3 multiple entries of the uploaded file.

Regards,
IDEVFH

Comment 34

[Wil Clouser [:clouserw]]

This bug is off track.  The original bug is fixed (or expired).  If there are additional bugs, please search for them and/or file them.

Comment 35

[Stephen Donner [:stephend] Not actively reading bugmail]

The original bug WFM on prod: https://addons.mozilla.org/en-US/firefox/addon/54456/eula/75791