540094 - [OOPP] unhandled winless plugin events are improperly serialized, should be ignored altogether

Status: RESOLVED WONTFIX

(Core Graveyard :: Plug-ins, defect, P3)

Description

[Jim Mathies [:jimm]]

<jimm> *** npevent->event = 281
<jimm> ###!!! [Child][RPCChannel] Error: Payload error: message could not be deserialized
<jimm> *** npevent->event = 282
<jimm> ###!!! [Child][RPCChannel] Error: Payload error: message could not be deserialized
<jimm> those are WM_IME_SETCONTEXT, and WM_IME_NOTIFY

http://hg.mozilla.org/projects/electrolysis/file/6f003829a096/dom/plugins/NPEventWindows.h#l66

Comment 2

[Brendan Eich [:brendan]]

Should this be fixed ASAP (3.6.6)?

/be

Comment 3

[[not reading bugmail]]

Would it reduce crashing/hangs if it were fixed on 3.6+?

Comment 4

[Christian Ascheberg]

bug 567936 is listed in the top ten crashers for Firefox 3.6.8. That bug is marked as a duplicate of bug 567645, which is marked as a duplicate of this bug. It also occurred to me, a few times in just a few minutes even.

Comment 5

[IU]

When will this be fixed?  Is there a possibility that this is responsible for the myriad responsiveness issues when running demanding flash videos and games?

Comment 6

[Jim Mathies [:jimm]]

(In reply to comment #5)
> When will this be fixed?  Is there a possibility that this is responsible for
> the myriad responsiveness issues when running demanding flash videos and games?

No, not likely. These are windowing events we don't deliver to flash via handle event. The original spec was very limited in what we delivered. Over time we've expanded this a bit, but I don't believe much of that is documented.

Comment 7

[Benjamin Smedberg]

I'd really like to turn on strict-aborting IPC error checking for plugins, but we need to fix this first. The obvious way to fix this is to avoid delivering these events at all.

Comment 8

[thewolf86]

Mafia Wars game on Facebook has 21 MILLION active monthly users and with the current Firefox m-c builds shows pretty terrible responsiveness on Flash heavy "Properties" page. IANAD but I think this bug is what's causing it, and if I'm right this should block the final release

21 million is a pretty large number of users.

Comment 9

[Benjamin Smedberg]

This bug has nothing to do with responsiveness, there are other bugs which address those persistent issues.

Comment 10

[Loic]

I experienced this crash event:
Firefox 3.6.12 Crash Report [@ hang | mozilla::plugins::PPluginInstanceParent::CallNPP_HandleEvent(mozilla::plugins::NPRemoteEvent const&, short*) ] 
http://crash-stats.mozilla.com/report/index/bp-ca3ca0bd-2a53-4531-b69c-881372101205
( linked to
Firefox 3.6.12 Crash Report [@ hang | KiFastSystemCallRet ]
http://crash-stats.mozilla.com/report/index/bp-94b7cf58-64a4-49b1-928f-960972101205 )

The 1st crash page links to the bug https://bugzilla.mozilla.org/show_bug.cgi?id=567936 tha redirects to this bug.

I was browsing a Flash streaming when FF froze completely. I had to wait for 1 min then the Flash plugin crashed (FF sent a report).

Comment 11

[Teo]

[@ hang | mozilla::plugins::PPluginInstanceParent::CallNPP_HandleEvent(mozilla::plugins::NPRemoteEvent const&, short*) ] 

Please add above to crash signature, so it is picked up on crash-stats.mozilla.com

Came here the long way.

567936 (is duplicate - has crash signature) ==> 567645 (duplicate) ==> this bug

Comment 12

[Teo]

https://crash-stats.mozilla.com/report/list?product=Firefox&query_search=signature&query_type=contains&query=mozilla%3A%3Aplugins%3A%3APPluginInstanceParent%3A%3ACallNPP_HandleEvent%28mozilla%3A%3Aplugins%3A%3ANPRemoteEvent%20const%26%2C%20short*%29&reason_type=contains&date=08%2F20%2F2011%2000%3A50%3A37&range_value=1&range_unit=weeks&hang_type=any&process_type=any&do_query=1&signature=hang%20|%20mozilla%3A%3Aplugins%3A%3APPluginInstanceParent%3A%3ACallNPP_HandleEvent%28mozilla%3A%3Aplugins%3A%3ANPRemoteEvent%20const%26%2C%20short*%29

Comment 13

[Carm]

reference: dd299209-46a3-41b2-8f84-214da2111011

Comment 14

[Carm]

playing/switching songs on this page, which does contain flash content: http://minus.com/mbcCOyzaYM#1l

https://crash-stats.mozilla.com/report/index/bp-7028cd52-47f7-4a03-aa9c-208522111115

https://crash-stats.mozilla.com/report/index/bp-9de4356b-9020-42ae-9e97-104582111115

More extensive documentation here: https://bugzilla.mozilla.org/show_bug.cgi?id=561019

Comment 15

[Sylvestre Ledru [:Sylvestre]]

Closing because no crash reported since 12 weeks.