540281 - rename nsAccessible::FireAccessibleEvent into HandleAccEvent

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 422086 [details] [diff] [review]
patch

r=me thanks.

>diff --git a/accessible/src/atk/nsAccessibleWrap.cpp b/accessible/src/atk/nsAccessibleWrap.cpp
>--- a/accessible/src/atk/nsAccessibleWrap.cpp
>+++ b/accessible/src/atk/nsAccessibleWrap.cpp
>@@ -1102,34 +1102,32 @@ nsAccessibleWrap *GetAccessibleWrap(AtkO
> 
>     if (tmpAppAccWrap != tmpAccWrap && !tmpAccWrap->IsValidObject())
>         return nsnull;
> 
>     return tmpAccWrap;
> }
> 
> nsresult
>-nsAccessibleWrap::FireAccessibleEvent(nsIAccessibleEvent *aEvent)
>+nsAccessibleWrap::HandleAccEvent(nsAccEvent *aEvent)

nice.

>--- a/accessible/src/base/nsAccessible.h
>+++ b/accessible/src/base/nsAccessible.h
>@@ -275,19 +275,20 @@ public:
>    * Return first child accessible only if cached.
>    */
>   nsAccessible* GetCachedFirstChild();
> 
>   //////////////////////////////////////////////////////////////////////////////
>   // Miscellaneous methods
> 
>   /**
>-   * Fire accessible event.
>+   * Handle accessible event, i.e. process it, notifies observers and fires
>+   * platform specific event.
>    */
>-  virtual nsresult FireAccessibleEvent(nsIAccessibleEvent *aAccEvent);
>+  virtual nsresult HandleAccEvent(nsAccEvent *aAccEvent);

Please update NS_ACCESSIBLE_IMPL_CID ;)

Comment 3

[alexander :surkov (:asurkov)]

(In reply to comment #2)
> (From update of attachment 422086 [details] [diff] [review])
> r=me thanks.
> >-  virtual nsresult FireAccessibleEvent(nsIAccessibleEvent *aAccEvent);
> >+  virtual nsresult HandleAccEvent(nsAccEvent *aAccEvent);
> 
> Please update NS_ACCESSIBLE_IMPL_CID ;)

sure, thanks :)

Comment 4

[alexander :surkov (:asurkov)]

landed on 1.9.3 - http://hg.mozilla.org/mozilla-central/rev/7a74aa79f2ea

Comment 5

[(no longer active)]

I backed out the patch because of build failures on Mac a11y enabled builds.

/Users/ehsanakhgari/moz/src/accessible/src/mac/nsAccessibleWrap.mm:163: error: no ‘nsresult nsAccessibleWrap::HandleAccEvent(nsAccEvent*)’ member function declared in class ‘nsAccessibleWrap’
/Users/ehsanakhgari/moz/src/accessible/src/mac/nsAccessibleWrap.mm: In member function ‘virtual nsresult nsAccessibleWrap::FirePlatformEvent(nsAccEvent*)’:
/Users/ehsanakhgari/moz/src/accessible/src/mac/nsAccessibleWrap.mm:188: error: ‘rv’ was not declared in this scope

The backout changeset is: http://hg.mozilla.org/mozilla-central/rev/e469ec1235e8.

Comment 6

[David Bolter [:davidb] (NeedInfo me for attention)]

Alexander note tryserver and central don't do mac a11y builds unless you force via mozconfig. (maybe this needs to land alongside bug 540285?)

Comment 7

[alexander :surkov (:asurkov)]

(In reply to comment #5)
> I backed out the patch because of build failures on Mac a11y enabled builds.

Thank you for doing this.

(In reply to comment #6)
> Alexander note tryserver and central don't do mac a11y builds unless you force
> via mozconfig. (maybe this needs to land alongside bug 540285?)

It would be great if they will. Bug 540285 doesn't touch mac a11y.

Comment 8

[alexander :surkov (:asurkov)]

Landed on 1.9.3 again with mac bustage fixes - http://hg.mozilla.org/mozilla-central/rev/f278332bcc6d