540634 - "Edit your review" functionality is broken on preview and Prod

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Pratibha]

User-Agent:       Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.9.1.3) Gecko/20091026 Firefox/3.5.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.7) Gecko/20091221 Firefox/3.5.7

Modification of the review by accessing Details Review page of a add-on and saving by "Submit your review" fails

Reproducible: Always

Steps to Reproduce:
1. Login to https://preview.mozilla.org
2. Search for an add-on
3. Go to the details page, "What do you think" section

Input some Review, Select Rating and click on "Post Review"
4. Review submitted succesfully page is dislayed: Click on "Back to <add-on>" taking to Details Page

Note: Review posted is displayed correctly
5. Now click on "Detailed Review" in What do you think section
6. Edit Review for <add-on> page: 
7. Input some text in "Title/Summary"
8. click on "Submit your Review"
Actual Results:  
In Detail Review Page: Submit your Review does not perform any action. The same page is displayed again

Expected Results:  
"Submit your review" updates the already existing review with new data

Comment 1

[Jeff Balogh (:jbalogh)]

This could be some hot caching action.  Could you check back in a few hours and see if your review has been updated?

We'll be fixing the lame caching in our move to zamboni. (http://micropipes.com/blog/2009/11/17/amo-development-changes-in-2010/)

Comment 2

[Pratibha]

Currently while testing AMO5.7, i see the same behavior,"Submit you review" is not working, thus unable to edit my review

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #2)
> Currently while testing AMO5.7, i see the same behavior,"Submit you review" is
> not working, thus unable to edit my review

I was able to add a review to https://preview.addons.mozilla.org/en-US/firefox/reviews/add/3456; Pratibha, can you try again?  Thanks!

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #3)
> (In reply to comment #2)
> > Currently while testing AMO5.7, i see the same behavior,"Submit you review" is
> > not working, thus unable to edit my review
> 
> I was able to add a review to
> https://preview.addons.mozilla.org/en-US/firefox/reviews/add/3456; Pratibha,
> can you try again?  Thanks!

NVM me, sorry; I can reproduce, actually.

Comment 5

[krupa raj[:krupa]]

The behavior in Prod is a little different-

On clicking Edit review,a new review form submit page loads as opposed to my existing review.

See also bugs-527751 and 440626

Comment 6

[Pratibha]

Verified at: https://addons.mozilla.org/en-US/firefox/addon/foxtab/reviews/add

Comment 7

[Pratibha]

Also verified "Edit Review" at:
https://addons.mozilla.org/en-US/firefox/addon/foxtab/reviews/