540732 - folder pane background color is incorrect

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: fix the folder pane background color

A heavy Mac user just pointed out how the color value for the Mac folder pane is incorrect.

The background color mimics the Finder sidebar color and we're currently using #D6DDE5 when the correct value is #DEE4EA

This difference is small but noticeable, a patch is attached to fix this problem.

philor, this is a difficult patch but I think you have the guts to take it on!

Comment 1

[Phil Ringnalda (:philor)]

Well, it sort of is a difficult patch: we use d6dde5, suite uses d6dde5 (which probably means that d6dde5 was the standard sidebar color in 10.2 or thereabouts), but Fx uses d4dde5, and on 10.5 according to ye olde DigitalColor Meter the Finder and Mail.app and Colloquy and Safari use d4dde5, while iTunes has to be weird and uses cfd7e3.

So, two questions: is dee4ea what the Finder and Mail.app and Colloquy and Safari all use on 10.6, and if so, will the conveniently cc'ed Markus be giving Fx a runtime determined constant for SIDEBAR_BACKGROUND_ON_THIS_VERSION_OF_OS_X that we can imitate, rather than having to decide that we want to look like 10.6 on 10.5?

Comment 2

[Markus Stange [:mstange]]

I can give us a platform color, sure, but I don't expect that to be taken on 1.9.2.x.

Comment 3

[Markus Stange [:mstange]]

(In reply to comment #1)
> So, two questions: is dee4ea what the Finder and Mail.app and Colloquy and
> Safari all use on 10.6

Correct.

Comment 4

[Phil Ringnalda (:philor)]

Comment on attachment 422422 [details] [diff] [review]
fix the folder pane background color

Yeah, since there's no chance of getting it right on 1.9.2, we're better off looking too new than looking too old.

Comment 5

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/39cb93ce16ba

Bryan if you want this in 3.0.x you'll have to nominate (although I'm not sure we do want/need it there).

Comment 6

[Bryan Clark (DevTools PM) [:clarkbw]]

Did a follow up on this over the weekend because I'm noticing that still some of the colors for the folder pane are just slightly off and gives the uncanny valley effect.  So far this seems as much of a question of 'Should we be iTunes or Finder?'  I should file a new bug for that question.

With either system we're missing a text-shadow color for the selected item so I've filed bug 554113 for that.

Here are my findings for colors -

According to Finder:

focus background-color
 currently: #dfe5eb;
 should be: #d7dee6;

focus, selected item
 currently: gradient image(#6495cf 0px, #6495cf 1px, #76a6dc 1px, #2f6eba)
 should be: -moz-linear-gradient(#4382c9 0px, #4382c9 1px, #5c96d7 1px, #0e54aa)

focus, selected - text-shadow
 currently: none
 should be: #113b6d 0 -1px

focus, unselected item
 currently: gradient image(#a4b1cb 0px, #a4b1cb 1px, #aebed8 1px, #8598b9)
 should be: selected-color, i.e. no difference

focus, unselected - text-shadow
 currently: none
 should be: selected-color, i.e. no difference

unfocus - background-color
 currently: #e9e9e9
 should be: #e9e9e9;

unfocus, selected - text-shadow
 currently: none
 should be: #5a5a5a 0 1px




According to iTunes:

focus background-color
 currently: #dfe5eb;
 should be: #dadfe8;

focus, selected item
 currently: gradient image(#6495cf 0px, #6495cf 1px, #76a6dc 1px, #2f6eba)
 should be: -moz-linear-gradient(#5594d2 0px, #5594d2 1px, #6ea6de 1px, #1e6cbb)

focus, selected - text-shadow
 currently: none
 should be: #14427a 0 -1px

focus, unselected item
 currently: gradient image(#a4b1cb 0px, #a4b1cb 1px, #aebed8 1px, #8598b9)
 should be: -moz-linear-gradient(#a1b0cc 0px, #a1b0cc 1px, #afbed8 1px, #8498b9)

focus, unselected - text-shadow
 currently: none
 should be: #525f79 0 -1px

unfocus background color
 currently: #e9e9e9;
 should be: #ededed;

unfocus selection color
 currently: gradient image (#a7a8a7 0px, #a7a8a7 1px, #c0c0c0 1px, #9b9b9b)
 should be: -moz-linear-gradient(#a1b0cc 0px, #a1b0cc 1px, #afbed8 1px, #8498b9);

unfocus, selected - text-shadow
 currently: none
 should be: #14427a 0 -1px

Both systems

Comment 7

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: folder pane color compare itunes, thunderbird, finder