Closed Bug 540841 Opened 16 years ago Closed 1 year ago

replying to email sent to 'undisclosed-recipients' generates 'CC' to undisclosed-recipients

Categories

(Thunderbird :: Message Compose Window, defect)

Product:
Thunderbird
Component:
Message Compose Window
Type:
defect

Tracking

(blocking-thunderbird5.0 -)

Status:
RESOLVED WORKSFORME
Tracking Flags:
Tracking Status
blocking-thunderbird5.0 --- -

People

(Reporter: djmarcus, Unassigned)

References

Details

(Keywords: regression, testcase, Whiteboard: [needs patch][no l10n impact])

Attachments

(3 files)

THe original email as '.eml' as requested
2.30 KB, message/rfc822
Details
Screen shot of the 'reply all' CC
9.02 KB, image/jpeg
Details
Proposed fix
5.48 KB, patch
Bienvenu
: review+
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.7) Gecko/20091221 Firefox/3.5.7 (.NET CLR 3.5.30729) Build Identifier: 3.0 When I 'replay all' to an email sent out to BCC ("undisclosed-recipients"), the email includes a 'CC' to 'undisclosed-recipients' which are, of course, not in my address book. I am forced to manually delete the CC line. TB 2 did not have this issue. Here's an example of the message that I was replying to (I xxx'd out the personal stuff): From - Wed Jan 20 07:39:04 2010 X-Account-Key: account1 X-UIDL: 0MWDgX-1NMir32tVh-00XJpm X-Mozilla-Status: 0003 X-Mozilla-Status2: 00000000 X-Mozilla-Keys: Return-Path: <xxxxx@xxxxxxxx.com> Delivery-Date: Wed, 20 Jan 2010 07:38:41 -0500 Received: from smtp102.biz.mail.re2.yahoo.com (smtp102.biz.mail.re2.yahoo.com [68.142.229.216]) by mx.perfora.net (node=mxus2) with ESMTP (Nemesis) id 0MWDgX-1NMir32tVh-00XJpm for xxxxx@xxxxx.com; Wed, 20 Jan 2010 07:38:40 -0500 Received: (qmail 7233 invoked from network); 20 Jan 2010 12:38:40 -0000 Received: from modemcable052.183-203-24.mc.videotron.ca (xxxxx@xx.xx.183.52 with plain) by smtp102.biz.mail.re2.yahoo.com with SMTP; 20 Jan 2010 04:38:40 -0800 PST X-Yahoo-SMTP: Bez7cA6swBDsJl1MHzGI28HVTDNQs4U- X-YMail-OSG: xy_AbooVM1ms06HPcG75YGmMj8QdZtcAEEpnszX7rkOkgAS00amovBmw.L3Mu4NT94mbVLb.2y6NfobofvrmKuVc35jhEcOxo86cSILEfUp.0V5R3o5i8HNmLKAxIfW9qSfItt4WCB0_aNtctKtg5ozRVf45nrSmKpvviEpI3WwnZ9q_wtXby8FedKAHsVL_9S3DbPB9jJ58Cu0alyHNYKBA98ULRHLQXHQhRu_bMwozBs.yCFuL74Qi1fT_ReEAZ3HyG_xiZKvjMLd8Ij7mXSwffEf_Hs7JNHpzBkvN9HJjilPavnbO76kwFMGnT_uqVdDXO3HrjkAyILgKc.F6rsoNwFcdzDr15oX0JzpNujkjMYstmtoJOkt6_qKuPslWpEbkFYDZmag_uf1IC_SgNW7arABdQj.h2P.w9IUND5_n_5HvH7mG5.HutbAuqd4FPyr0jjFBZwUAb2W4c3Qh69FFMMl88MYx8TRgxFi2tVbWC3M133bUnad84DGXi4pbxtC.GKpqeAag8tlDPuyRetpELkEuwPTlCmq40gJCFrS. X-Yahoo-Newman-Property: ymail-3 Message-ID: <4B56F952.4030807@xxxxx.com> Date: Wed, 20 Jan 2010 07:38:42 -0500 From: "xxxxx" <xxxxx@xxxxx.com> User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: undisclosed-recipients: ; Subject: Don't miss today's astronomy picture of the day X-Stationery: 0.5.1 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Envelope-To: xxxxx@xxxxx.com <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> <head> <title></title> </head> <body bgcolor="#ffffff" text="#000000"> <style> A:link {color : #006697;} A:visited {color : #006697;} A:active {color : #006697;} A:hover {color : #6B83BB;} </style> <a class="moz-txt-link-freetext" href="http://antwrp.gsfc.nasa.gov/apod/ap100120.html">http://antwrp.gsfc.nasa.gov/apod/ap100120.html</a><br> <br> :-)<br> <br> <br> <br> <br> Claude<br> </body> </html> Reproducible: Always Steps to Reproduce: See attached message in 'Details' above. Expected Results: The 'undisclosed-recipients' should be recognized as such an filtered out in th 'reply all'
can you save the email you pasted here, in .eml format , and attach it using the add an attachment link above ?
Component: General → Mail Window Front End
Keywords: regression
QA Contact: general → front-end
When I 'reply all' there is a CC to 'undisclosed-recipients'
reproduced with 3.0.2pre David J, can you find the regression range? see http://www.rumblingedge.com/2009/02/24/howto-find-regression-windows-through-manual-binary-search/
Severity: normal → minor
Status: UNCONFIRMED → NEW
Component: Mail Window Front End → Message Compose Window
Ever confirmed: true
Keywords: regressionwindow-wanted, testcase
QA Contact: front-end → message-compose
Version: unspecified → 3.0
I think this is fixed in recent comm-central nightlies. I am using "Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a2pre) Gecko/20100223 Shredder/3.2a1pre", and "undisclosed-recipients" is not even displayed in the To: field of the received mail anymore. Replying to such a mail does not Cc: "undisclosed-recipients".
And now it has stopped working; i.e., Cc: undisclosed-recipients; is back. Still using the nightlies and am seeing this in Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a5pre) Gecko/20100601 Shredder/3.2a1pre.
Will get this on my plate to see if I can repro and get a regression window.
Assignee: nobody → gary
(In reply to comment #7) > Will get this on my plate to see if I can repro and get a regression window. This is tricky, when pressing "reply all" on that testcase in comment 2, I get that "undisclosed-recipients" cc reproduced with: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b13pre) Gecko/20110302 Thunderbird/3.3a3pre and with the 2010-06-01 nightly, but an error displaying the compose window in the 2010-03-01 and the 2010-05-01 nightly. Going back further in time, probably around the turn of 2009 into 2010 results in a strlen crash which I'm not sure if it's related. Will poke more.
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a5pre) Gecko/20100518 Shredder/3.2a1pre displays the compose window error but not the 20100519 one. The 20100519 one instead displays the undesired "undisclosed-recipients" cc. http://hg.mozilla.org/comm-central/pushloghtml?fromchange=f2e97ca98a85&tochange=d10d41621556 Highly likely to be bug 549931.
Blocks: 549931
blocking-thunderbird5.0: --- → ?
Keywords: regressionwindow-wanted
OS: Windows 7 → All
Hardware: x86_64 → All
Version: 3.0 → Trunk
Back to the pool, regressWin work done :)
Assignee: gary → nobody
blocking-thunderbird5.0: ? → needed
Tentatively taking.
Assignee: nobody → mbanner
Whiteboard: [needs patch][no l10n impact]
blocking-thunderbird5.0: needed → beta2+
Attached patch Proposed fix — — Splinter Review
I think this fixes the issue sufficiently well. It makes extractHeaderAddressMailboxes return an empty string instead of group syntax, but keeps extractHeaderAddressName(s) returning the full group syntax, i.e. names and addresses. This means that when we receive email using the group syntax, we'll still display it to users, however when it comes to replying, or processing the address, there will be no emailed addresses returned for the group. For empty groups, this is expected and isn't a problem anyway. For non-empty groups, it could cause a problem, but looking at the previous tests in test_splitRecipients it appears we weren't handling group syntax well anyway. I want to do a quick check back across versions, but I think this is a reasonable fix for 5.0. We can deal with proper group handling (which we've never had afaik) in follow-up bugs.
Attachment #540430 - Flags: review?(dbienvenu)
Comment on attachment 540430 [details] [diff] [review] Proposed fix do you want a follow-on bug for remaining issues, or leave this one open?
Attachment #540430 - Flags: review?(dbienvenu) → review+
Now we've investigated this a bit more, we realise that: Bug 242693 "fixed" this by not handling groups at all, and bug 549931 reverted it to the original state of handling groups. Given that we're now in the same state as all previously released versions (2.0, 3.0, 3.1). We're also not going to take the patch at this stage for TB 5 as it touches risky code and doesn't quite cover everything it should do.
blocking-thunderbird5.0: beta2+ → -
Assignee: mbanner → nobody
Severity: minor → S4

Cannot reproduce on TB 115 @ Win10-64bit.
I am not sure if I followed the same steps as the reporter.

My steps:
  1. importing the .eml from https://bugzilla.mozilla.org/attachment.cgi?id=422744 into Inbox
  2. right-click on the email
  3. in context-menu click on reply to all
actual results:

I don't have "undisclosed recipients". Neither in CC nor in BCC.

Thanks chrizilla.

WFM per comment 15

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → WORKSFORME
Summary: Responding to email sent to 'undisclosed-recipients' generates 'CC' to undisclosed-recipients → replying to email sent to 'undisclosed-recipients' generates 'CC' to undisclosed-recipients
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: