540972 - Fix install service add-on icons

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P2)

Description

[Justin Scott [:fligtar]]

We apparently broke the old add-on icon URLs when images were moved out of the database, and for some reason didn't add redirects.

The install service icons are now all missing, so we either need to add a redirect as should have been done originally or update all of the icon URLs in webroot/services/install.php and make certain nothing else is trying to use those URLs.

An example of the missing icon: http://people.mozilla.com/~fligtar/temp/kev.html

Comment 1

[Wil Clouser [:clouserw]]

Attachment: add a question mark

what do you think of this?

Comment 2

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Comment on attachment 423378 [details] [diff] [review]
add a question mark

Didn't realize we were inconsistent with this URL, but the ? fixes things if you forget the slash.

-d

Comment 3

[Wil Clouser [:clouserw]]

r61137

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

In trying to verify this, I tried using TamperData to intercept calls to the SAMO API and replace with preview.*, but it still pulled from prod; even replacing extensions.* URLs to point to preview didn't work.

Suggestions?

Comment 5

[Wil Clouser [:clouserw]]

I verified it by grabbing a normal URL from prod using tamperdata, and then changing that to preview.  It's not to the level of verification of actually using it in the client, but a request is a request and it should still work.

Comment 6

[Wil Clouser [:clouserw]]

I used https://preview.addons.mozilla.org/en-US/firefox/images/addon_icon/5202 vs https://addons.mozilla.org/en-US/firefox/images/addon_icon/5202

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Ahhhh, thanks, Wil.

Verified FIXED; that's precisely what I couldn't get at when I tried with TamperData.

clouserw++