54107 - Menulists sometimes drawn too small, and not defaulting to crop text

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect, P2)

Description

[hangas]

In Modern the menulists (widget that works like Windows drop-down) are often 
drawn too small making many dialogs and some top level windows look very bad.  
This problem is caused by an extra flex="1" inside the Modern xbl for menulist.

In all skins the text shown in a menulist is not cropped by default so some of 
our menulist widgets draw text over the end of the menulist.  This change is to 
add crop="right" on the xbl for menulist.

Joe is ready to make these two one-line changes.

Comment 1

[hangas]

These menu lists make many of our windows and dialogs seem broken and look really 
bad.  Marking nsbeta3+, looking for ++.

Comment 2

[Peter Trudelle]

PDT marking nsbeta3++

Comment 3

[Joe Hewitt (gone)]

*** Bug 54292 has been marked as a duplicate of this bug. ***

Comment 4

[Simon Fraser [no longer active]]

Any progress here?

Comment 5

[Joe Hewitt (gone)]

I'm about to check in a fix for the "too small" problem.  Leaving the crop 
problem behind for now because testing has shown that some menulists hide their 
contents when cropped (such as on prefs > fonts, the font size menulists) 
because they're too small.  

Please note that menulists are still a bit jumpy even with this fix.  This has 
to do with a focus issue that will be resolved when the fix for #54073 is 
checked in for RTM.

Comment 6

[Joe Hewitt (gone)]

Fixed.

Comment 7

[hangas]

*** Bug 53085 has been marked as a duplicate of this bug. ***

Comment 8

[Patty Mac]

work ok on all platforms (2999-09-28-10-MN6).

Comment 9

[Charles Manske]

I'm not pleased with this fix if it means that a closed menulist doesn't size
to the longest menuitem text. We shouldn't have menulists with "..." for the 
closed-state text unless the size of the menulist was restricted by CSS values.

Comment 10

[hangas]

*** Bug 53508 has been marked as a duplicate of this bug. ***